Skip to content

feat: implement runtime base url configuration#310

Merged
mustaphaturhan merged 2 commits intomasterfrom
feat/add-option-for-base-url
Jan 14, 2026
Merged

feat: implement runtime base url configuration#310
mustaphaturhan merged 2 commits intomasterfrom
feat/add-option-for-base-url

Conversation

@mustaphaturhan
Copy link
Collaborator

🛠️ Fixes Issue

Closes #308

👨‍💻 Changes proposed

  • Makes sections in the settings panel collapsible.
  • Adds new server settings to change base url in the runtime.
    • We are sending a request to <input-url>/status endpoint after user changed the URL. It throws an error if the URL is not in a URL format, or it is not reachable, or doesn't respond in 5 seconds or doesn't return correct response. If we get a response, we are checking route and isochrone in available_actions. If they are not presented in the result, we also doesn't let the change of base url
  • We are saving the changed base url to local storage. If user refresh the page, they will continue to see new base url they set.
  • There is also a "reset base url" button in the panel. If user clicks it, the base url will return back to the value set in the VITE_VALHALLA_URL environment variable.

📄 Note to reviewers

I haven't given much thought to security but since everything happens in the user's computer, I don't think there will be a problem.

📷 Screenshots

image image image image

@ghost
Copy link

ghost commented Jan 14, 2026

Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/310

nilsnolde
nilsnolde previously approved these changes Jan 14, 2026
Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again thanks for the super quick implementation:)

Makes sections in the settings panel collapsible.

nice touch!

@mustaphaturhan
Copy link
Collaborator Author

@nilsnolde one more approve please? 🙏🏻 I changed the fetching method.

@mustaphaturhan mustaphaturhan merged commit 8eaf71e into master Jan 14, 2026
3 checks passed
@mustaphaturhan mustaphaturhan deleted the feat/add-option-for-base-url branch January 14, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option for base URL

2 participants