feat: implement runtime base url configuration#310
Merged
mustaphaturhan merged 2 commits intomasterfrom Jan 14, 2026
Merged
Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/310 |
nilsnolde
previously approved these changes
Jan 14, 2026
Member
nilsnolde
left a comment
There was a problem hiding this comment.
again thanks for the super quick implementation:)
Makes sections in the settings panel collapsible.
nice touch!
…s not changed and use tanstack/query
Collaborator
Author
|
@nilsnolde one more approve please? 🙏🏻 I changed the fetching method. |
nilsnolde
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes Issue
Closes #308
👨💻 Changes proposed
<input-url>/statusendpoint after user changed the URL. It throws an error if the URL is not in a URL format, or it is not reachable, or doesn't respond in 5 seconds or doesn't return correct response. If we get a response, we are checking route and isochrone inavailable_actions. If they are not presented in the result, we also doesn't let the change of base urlVITE_VALHALLA_URLenvironment variable.📄 Note to reviewers
I haven't given much thought to security but since everything happens in the user's computer, I don't think there will be a problem.
📷 Screenshots