Skip to content

add attributes popup#315

Merged
mustaphaturhan merged 2 commits intomasterfrom
issue-307/add-features-popup
Jan 23, 2026
Merged

add attributes popup#315
mustaphaturhan merged 2 commits intomasterfrom
issue-307/add-features-popup

Conversation

@mustaphaturhan
Copy link
Collaborator

🛠️ Fixes Issue

Closes #307

👨‍💻 Changes proposed

  • Adds new features/attributes popup to show when user click valhalla layers in tiles view
  • Context menu will not work for tiles tab anymore since nothing there is nothing related with tiles on it
  • Removes unnecessary dependency, @maplibre/maplibre-gl-inspect
  • Map tests were giving a warning about missing acts, adds that.

📷 Screenshots

image image

@ghost
Copy link

ghost commented Jan 22, 2026

Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/315

Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! A few things:

  • maybe it's better to display the attributes in alphabetical order?
  • there's a bunch of enums where we only return the index which we should map again to their string values (eg road_class). I'll circle back later with those attributes and their mappings

@nilsnolde
Copy link
Member

nilsnolde commented Jan 23, 2026

actually you can copy/paste these maps:

https://github.com/valhalla/demos/blob/aab1cd6d118703529c0f32e240271592b02e7f82/tile/index.html#L275-L311

also regarding alphabetical order: on second thought I actually like that the service is in charge of ordering the attributes and we can re-arrange there instead of in the app.

@nilsnolde
Copy link
Member

nilsnolde commented Jan 23, 2026

what could also be nice: wrap the osm_id into a URL, so 730703719 -> https://www.openstreetmap.org/way/730703719. for edges, that property will always have a proper value. for nodes, we'll still have to add it on the backend.

@mustaphaturhan
Copy link
Collaborator Author

@nilsnolde I updated the visuals of the popup (thanks to opus 4.5 since I couldn't picture a good design in my head 😄)
image

I updated the values and mapped them with same values in https://github.com/valhalla/demos/blob/aab1cd6d118703529c0f32e240271592b02e7f82/tile/index.html#L275-L311.

I also updated the property renderer of osm_way_id, now it will be a link.

Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, thanks @mustaphaturhan!

@mustaphaturhan mustaphaturhan merged commit 1d99c61 into master Jan 23, 2026
3 checks passed
@mustaphaturhan mustaphaturhan deleted the issue-307/add-features-popup branch January 23, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dedicated /tile UX to (de-)select layers & attribute popups on feature left-click

2 participants