Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/315 |
nilsnolde
left a comment
There was a problem hiding this comment.
Great, thanks! A few things:
- maybe it's better to display the attributes in alphabetical order?
- there's a bunch of enums where we only return the index which we should map again to their string values (eg road_class). I'll circle back later with those attributes and their mappings
|
actually you can copy/paste these maps: also regarding alphabetical order: on second thought I actually like that the service is in charge of ordering the attributes and we can re-arrange there instead of in the app. |
|
what could also be nice: wrap the |
|
@nilsnolde I updated the visuals of the popup (thanks to opus 4.5 since I couldn't picture a good design in my head 😄) I updated the values and mapped them with same values in https://github.com/valhalla/demos/blob/aab1cd6d118703529c0f32e240271592b02e7f82/tile/index.html#L275-L311. I also updated the property renderer of |
nilsnolde
left a comment
There was a problem hiding this comment.
Looks very nice, thanks @mustaphaturhan!

🛠️ Fixes Issue
Closes #307
👨💻 Changes proposed
@maplibre/maplibre-gl-inspectacts, adds that.📷 Screenshots