Skip to content

remove units for non-speed live traffic properties in tile popup #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrstnbwnkl merged 1 commit into from
Jan 28, 2026
Merged

remove units for non-speed live traffic properties in tile popup #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/components/map/parts/tiles-property.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,19 @@ describe('TilesProperty', () => {
});
});

describe('live traffic breakpoints and congestion', () => {
it('should show speed without km/h unit', () => {
render(
<TilesProperty
propertyKey="live_traffic:forward:congestion0"
value={50}
/>
);
expect(screen.getByText('50')).toBeInTheDocument();
expect(screen.queryByText('km/h')).not.toBeInTheDocument();
});
});

describe('slope values', () => {
it('should show slope with degree unit', () => {
render(<TilesProperty propertyKey="max_up_slope" value={5} />);
Expand Down
5 changes: 4 additions & 1 deletion src/components/map/parts/tiles-property.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ export function TilesProperty({
);
}

if (propertyKey.includes('speed')) {
if (
propertyKey.includes('speed') &&
!(propertyKey.includes('congestion') || propertyKey.includes('breakpoint'))
) {
return (
<span className="font-mono text-xs">
{String(value)}
Expand Down