Merged
Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/319 |
mustaphaturhan
previously approved these changes
Jan 29, 2026
Collaborator
mustaphaturhan
left a comment
mustaphaturhan
left a comment
There was a problem hiding this comment.
looks fine to me. it could be nice if we can remove the console.logs.
radix and base-ui come from the same maintainers. with the new version of shadcn, we are able to select radix or base-ui while creating the application. it looks looks like radix version of combobox is gone. they re-built combobox with base-ui primitives.
| )} | ||
| {profileSettings[profile as ProfileWithSettings].list.map( | ||
| (option, key) => { | ||
| console.log(`setting: ${settings[option.param]}`); |
Collaborator
There was a problem hiding this comment.
should we remove console.logs?
Member
Author
There was a problem hiding this comment.
whoops, thanks for catching those.
mustaphaturhan
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a combobox to select the different speed types to use as a costing option, enabled for profiles that use traffic speeds.
I later realized that the Combobox component is based on BaseUI rather than radix (which is what we're using). Not ideal to pull in another dependency, but I don't know what the state of radix vs baseUI is, it seems to come from the same maintainers?