Merged
Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/355 |
nilsnolde
reviewed
Mar 6, 2026
Member
nilsnolde
left a comment
nilsnolde
left a comment
There was a problem hiding this comment.
thanks, LGTM. other than the 1 change request.
src/components/tiles/tiles.tsx
Outdated
Comment on lines
+210
to
+222
| <p className="text-xs text-muted-foreground"> | ||
| Display tile grid overlay with coordinates and file sizes. Uses | ||
| MapLibre's{' '} | ||
| <a | ||
| href="https://maplibre.org/maplibre-gl-js/docs/API/classes/Map/#showtileboundaries" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="text-primary underline hover:no-underline" | ||
| > | ||
| debug mode | ||
| </a>{' '} | ||
| for inspecting map tiles. | ||
| </p> |
Member
There was a problem hiding this comment.
we should remove the subtext from both input controls IMO. it's quite obvious what both do once they're toggled
Contributor
Author
|
thanks for the quick review!! removed subtext from both toggle controls and updated tests. All checks passing. |
nilsnolde
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #351
What this adds
Added a toggle switch in the Tiles tab to enable MapLibre's tile boundary debug mode. When enabled, shows:
Implementation
Added "MVT Debug" toggle that sets
map.showTileBoundaries. Positioned it right after the Valhalla layers toggle to keep debug features together.The toggle follows the same UI pattern as the Valhalla layers toggle - includes a description with link to MapLibre docs.
Note: AI assisted with code implementation. I researched the MapLibre API, designed the UI, and tested the feature.