Skip to content

Convert popup buttons to labels and remove locate points#359

Merged
nilsnolde merged 3 commits intovalhalla:masterfrom
thisisharsh7:fix/data-popup
Mar 8, 2026
Merged

Convert popup buttons to labels and remove locate points#359
nilsnolde merged 3 commits intovalhalla:masterfrom
thisisharsh7:fix/data-popup

Conversation

@thisisharsh7
Copy link
Contributor

@thisisharsh7 thisisharsh7 commented Mar 7, 2026

This PR refactor the map info popup.

Changes -

  1. Remove all the button definition inside the popup code and changes into the html div element
  2. Remove the Locate points button and it's api definition
  3. Add styling changes
  4. Used ternary condition in className such that we can control the ui when the ui component only has label no copy button.
  5. Updated tests with this new refactored UI

Closes #356

Note - I investigated the bug and wrote the code for fixes the bug. AI is used in writing test code and debugging the tests failure.

Edit 1:
Fix failing playwright tests caused by the popup refactor. Updated test accordingly. (AI-assisted)

@ghost
Copy link

ghost commented Mar 8, 2026

Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/359

Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, finally a PR removing some code:)

@nilsnolde nilsnolde merged commit 1954576 into valhalla:master Mar 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking "Valhalla Location JSON" button doesn't copy, only the icon does

2 participants