-
Notifications
You must be signed in to change notification settings - Fork 63
Add docs to accompany AMD-accelerated OPEA ChatQnA pattern #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is an automated message: You can preview this docs PR at http://567.docs-pr.validatedpatterns.io |
|
Hi @jeremyary. Thanks for your PR. I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/lgtm |
abhatt-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeremyary
Thank you for submitting this PR. On a cursory look, I have a added a couple of style-related comments based IBM Style and Red Hat Supplementary Style guides.
| #pattern_logo: amd-rag-chat-qna.png | ||
| links: | ||
| install: amd-rag-chat-qna-getting-started | ||
| help: https://groups.google.com/g/hybrid-cloud-patterns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| help: https://groups.google.com/g/hybrid-cloud-patterns | |
| help: https://groups.google.com/g/validatedpatterns |
| = About {amdqna-pattern} | ||
|
|
||
| Background:: | ||
| This Validated Pattern implements an enterprise-ready question-and-answer chatbot utilizing retrieval-augmented generation (RAG) & capability reasoning via large language model (LLM). The application is based on the publicly-available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This Validated Pattern implements an enterprise-ready question-and-answer chatbot utilizing retrieval-augmented generation (RAG) & capability reasoning via large language model (LLM). The application is based on the publicly-available | |
| This Validated Pattern implements an enterprise-ready question-and-answer chatbot utilizing retrieval-augmented generation (RAG) and capability reasoning using large language model (LLM). The application is based on the publicly-available |
| This pattern aims to leverage the strengths of OPEA's framework in combination with other OpenShift-centric toolings in order to deploy a modern, LLM-backed reasoning application stack capable of leveraging https://www.amd.com/en/products/accelerators/instinct.html[AMD's Instinct] | ||
| hardware acceleration in an enterprise-ready & distributed manner. The pattern utilizes https://www.redhat.com/en/technologies/cloud-computing/openshift/gitops[Red Hat OpenShift GitOps] to bring a continuous delivery approach to the application's development & usage based on declarative | ||
| Git-driven workflows, backed by a centralized, single-source-of-truth git repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove hard line breaks
| hardware acceleration in an enterprise-ready & distributed manner. The pattern utilizes https://www.redhat.com/en/technologies/cloud-computing/openshift/gitops[Red Hat OpenShift GitOps] to bring a continuous delivery approach to the application's development & usage based on declarative | ||
| Git-driven workflows, backed by a centralized, single-source-of-truth git repository. | ||
|
|
||
| Key Features:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Key Features:: | |
| Key features:: |
| The following solution integrates the https://github.com/opea-project/GenAIExamples/tree/main/ChatQnA[OPEA ChatQnA example app] with the http://localhost:1313/patterns/multicloud-gitops/[Multicloud GitOps] Validated Pattern to encapsulate every defined component as an | ||
| easily trackable resource via OpenShift GitOps dashboard: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove hard line break
| Once all the prerequisites are met, install the ChatQnA application | ||
| * Clone the repository by running the following commands: | ||
| + | ||
| git clone https://github.com/validatedpatterns-sandbox/qna-chat-amd.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Global comment: Use appropriate code blacks for commands and code snippets
| git clone https://github.com/validatedpatterns-sandbox/qna-chat-amd.git | |
| [source,terminal] | |
| git clone https://github.com/validatedpatterns-sandbox/qna-chat-amd.git |
| + | ||
| * Modify the `value` field in `~/values-secret-qna-chat-amd.yaml` file | ||
| + | ||
| ---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ---- | |
| [source,yaml] | |
| ---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason it didn't recognize the fix for this one, but it's in there.
| + | ||
| image::/images/qna-chat-amd/chatqna-long-response.png[ChatQnA UI - response for general questions,50%,50%] | ||
|
|
||
| === Wrap Up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| === Wrap Up | |
| === Conclusion |
| @@ -0,0 +1,41 @@ | |||
| --- | |||
| title: Required Hardware | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Global comment: Write all titles and headings, in sentence-style capitalization.
| title: Required Hardware | |
| title: Required hardware |
| include::modules/comm-attributes.adoc[] | ||
|
|
||
| [id="troubleshooting-the-pattern-deployment"] | ||
| === Troubleshooting common Pattern Deployment issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| === Troubleshooting common Pattern Deployment issues | |
| === Troubleshooting common pattern deployment issues |
|
Thanks @abhatt-rh & @day0hero, all recommended changes implemented, incl. global comments and a few similar things I caught. |
abhatt-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeremyary,
Thank you for addressing the comments. Please squash all the commits to one. I have added a comment for AMD to show up under our Partners filter like shown here:

| - Red Hat OpenShift Data Foundation | ||
| - Red Hat OpenShift AI | ||
| - Red Hat OpenShift Serverless | ||
| - Red Hat OpenShift Service Mesh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the following lines to add AMD as Partner. This will bring up your pattern should anyone filter on AMD:
partners:
- AMD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh, solid improvement for search, thank you! Added & commits squashed.
abhatt-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Proceeding with merge
Accompanying pattern code here: https://github.com/validatedpatterns-sandbox/qna-chat-amd