Skip to content

Conversation

@jeremyary
Copy link
Contributor

Accompanying pattern code here: https://github.com/validatedpatterns-sandbox/qna-chat-amd

  • Adding documentation for new pattern which deploys OPEA's ChatQnA app and enables AMD Instinct hardware acceleration
  • similar to existing Intel-contributed pattern for Gaudi accel.
  • card/pattern reflect sandbox status indicator

@mbaldessari
Copy link
Contributor

This is an automated message:

You can preview this docs PR at http://567.docs-pr.validatedpatterns.io
Note that they get generated every five minutes, so please wait a bit.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2025

Hi @jeremyary. Thanks for your PR.

I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the size/XL label May 12, 2025
@jeremyary jeremyary marked this pull request as ready for review May 12, 2025 15:47
@jeremyary jeremyary changed the title Add docs to accompany AMD-acceleraed OPEA ChatQnA pattern Add docs to accompany AMD-accelerated OPEA ChatQnA pattern May 12, 2025
@mbaldessari
Copy link
Contributor

/ok-to-test

@day0hero
Copy link
Contributor

/lgtm

Copy link
Collaborator

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jeremyary
Thank you for submitting this PR. On a cursory look, I have a added a couple of style-related comments based IBM Style and Red Hat Supplementary Style guides.

#pattern_logo: amd-rag-chat-qna.png
links:
install: amd-rag-chat-qna-getting-started
help: https://groups.google.com/g/hybrid-cloud-patterns
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help: https://groups.google.com/g/hybrid-cloud-patterns
help: https://groups.google.com/g/validatedpatterns

= About {amdqna-pattern}

Background::
This Validated Pattern implements an enterprise-ready question-and-answer chatbot utilizing retrieval-augmented generation (RAG) & capability reasoning via large language model (LLM). The application is based on the publicly-available
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This Validated Pattern implements an enterprise-ready question-and-answer chatbot utilizing retrieval-augmented generation (RAG) & capability reasoning via large language model (LLM). The application is based on the publicly-available
This Validated Pattern implements an enterprise-ready question-and-answer chatbot utilizing retrieval-augmented generation (RAG) and capability reasoning using large language model (LLM). The application is based on the publicly-available

Comment on lines 39 to 41
This pattern aims to leverage the strengths of OPEA's framework in combination with other OpenShift-centric toolings in order to deploy a modern, LLM-backed reasoning application stack capable of leveraging https://www.amd.com/en/products/accelerators/instinct.html[AMD's Instinct]
hardware acceleration in an enterprise-ready & distributed manner. The pattern utilizes https://www.redhat.com/en/technologies/cloud-computing/openshift/gitops[Red Hat OpenShift GitOps] to bring a continuous delivery approach to the application's development & usage based on declarative
Git-driven workflows, backed by a centralized, single-source-of-truth git repository.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hard line breaks

hardware acceleration in an enterprise-ready & distributed manner. The pattern utilizes https://www.redhat.com/en/technologies/cloud-computing/openshift/gitops[Red Hat OpenShift GitOps] to bring a continuous delivery approach to the application's development & usage based on declarative
Git-driven workflows, backed by a centralized, single-source-of-truth git repository.

Key Features::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Key Features::
Key features::

Comment on lines 53 to 54
The following solution integrates the https://github.com/opea-project/GenAIExamples/tree/main/ChatQnA[OPEA ChatQnA example app] with the http://localhost:1313/patterns/multicloud-gitops/[Multicloud GitOps] Validated Pattern to encapsulate every defined component as an
easily trackable resource via OpenShift GitOps dashboard:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hard line break

Once all the prerequisites are met, install the ChatQnA application
* Clone the repository by running the following commands:
+
git clone https://github.com/validatedpatterns-sandbox/qna-chat-amd.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global comment: Use appropriate code blacks for commands and code snippets

Suggested change
git clone https://github.com/validatedpatterns-sandbox/qna-chat-amd.git
[source,terminal]
git clone https://github.com/validatedpatterns-sandbox/qna-chat-amd.git

+
* Modify the `value` field in `~/values-secret-qna-chat-amd.yaml` file
+
----
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
----
[source,yaml]
----

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason it didn't recognize the fix for this one, but it's in there.

+
image::/images/qna-chat-amd/chatqna-long-response.png[ChatQnA UI - response for general questions,50%,50%]

=== Wrap Up
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=== Wrap Up
=== Conclusion

@@ -0,0 +1,41 @@
---
title: Required Hardware
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global comment: Write all titles and headings, in sentence-style capitalization.

Suggested change
title: Required Hardware
title: Required hardware

include::modules/comm-attributes.adoc[]

[id="troubleshooting-the-pattern-deployment"]
=== Troubleshooting common Pattern Deployment issues
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=== Troubleshooting common Pattern Deployment issues
=== Troubleshooting common pattern deployment issues

@openshift-ci openshift-ci bot removed the lgtm label May 15, 2025
@jeremyary
Copy link
Contributor Author

Thanks @abhatt-rh & @day0hero, all recommended changes implemented, incl. global comments and a few similar things I caught.

Copy link
Collaborator

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jeremyary,
Thank you for addressing the comments. Please squash all the commits to one. I have added a comment for AMD to show up under our Partners filter like shown here:
image

- Red Hat OpenShift Data Foundation
- Red Hat OpenShift AI
- Red Hat OpenShift Serverless
- Red Hat OpenShift Service Mesh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following lines to add AMD as Partner. This will bring up your pattern should anyone filter on AMD:

partners:
- AMD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, solid improvement for search, thank you! Added & commits squashed.

Copy link
Collaborator

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Proceeding with merge

@openshift-ci openshift-ci bot added the lgtm label May 16, 2025
@abhatt-rh abhatt-rh merged commit d808211 into validatedpatterns:main May 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants