fix(ansible): add error handling and explicit configuration #555
+23
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
site.yaml: - Add task to verify pattern.sh exists before execution - Use playbook_dir instead of PWD lookup for reliable path resolution - Add failed_when condition to properly handle command failures - Print stdout_lines instead of full output object - Conditionally print stderr if present ansible.cfg: - Add interpreter_python=auto_silent to suppress interpreter warnings - Add host_key_checking=False for non-interactive execution - Add timeout=30 to prevent hanging on slow systems - Add comment documenting why retry_files_enabled is False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
site.yaml:
ansible.cfg:
Test Plan
ansible-playbook --syntax-check ansible/site.yamlFixes #543
Fixes #544
Fixes #545
Fixes #546
Fixes #547
Fixes #548
Fixes #549
Fixes #550
Fixes #551