Update v1 branch #46
Merged
Update v1 branch #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Sep 1, 2025
mbaldessari
commented
- Use spec.managedClusterClientConfigs[].url to get the spoke endpoint
- Reduce the usage of the acm secret filter and support ACM 2.13
- Fix some ansible linting issues
Since in ACM 2.13 the cluster secrets are no more (in favour of managed service accounts), let's start using the url from the managedCluster CRs since those exist both in 2.12 and 2.13. This will simplify our later work.
ACM 2.13 uses managed service accounts so there is no <spoke>-cluster secret anymore to parse. Instead we look for a secret called 'application-manager' inside the namespace for the spoke cluster. That secret contains the bearerToken. We still keep 2.12 compatibility and only run this when we cannot find the <spoke>-cluster secret. Tested on both ACM 2.13 and 2.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.