updating s3-create for contraint issue#150
Merged
mbaldessari merged 1 commit intovalidatedpatterns:mainfrom Jan 14, 2025
Merged
updating s3-create for contraint issue#150mbaldessari merged 1 commit intovalidatedpatterns:mainfrom
mbaldessari merged 1 commit intovalidatedpatterns:mainfrom
Conversation
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating s3-create.py to:
The script skips CreateBucketConfiguration when the region is us-east-1.
Added a more robust check for missing or empty AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY.
Ensures proper application of public access settings and bucket policies if the --public flag is used.