Skip to content

test: Update fixtures/no-lang.html to include more text content#212

Merged
XhmikosR merged 1 commit intomainfrom
sideshowbarker/no-lang-add-text-content
Nov 3, 2025
Merged

test: Update fixtures/no-lang.html to include more text content#212
XhmikosR merged 1 commit intomainfrom
sideshowbarker/no-lang-add-text-content

Conversation

@sideshowbarker
Copy link
Member

No description provided.

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/no-lang-add-text-content branch from 2bc8130 to eb7011f Compare November 3, 2025 07:43
sideshowbarker referenced this pull request Nov 3, 2025
@XhmikosR XhmikosR merged commit 44e8694 into main Nov 3, 2025
16 checks passed
@XhmikosR XhmikosR deleted the sideshowbarker/no-lang-add-text-content branch November 3, 2025 08:06
@XhmikosR
Copy link
Member

@sideshowbarker not sure where to ping you, I hope you see it :)

So, with the new "rolling" releases this package and gulp-html are basically useless. They cannot follow this pattern as things are right now...

@sideshowbarker
Copy link
Member Author

So, with the new "rolling" releases this package and gulp-html are basically useless. They cannot follow this pattern as things are right now...

I hear you and I understand — but my personal situation is such that for the foreseeable future, I won’t be able to make time to manually do any more numbered releases.

The time that I’ve carved out over the last few months to just get the checker code and infrastructure up to date (after 3 years or more of having not been able to do much really-substantial maintenance and updates on it) has … already cost me quite a lot. And now that I kind of finally do have the checker “stabilized”, I’m actualy soon going to need to go back to spending much less of my time on it.

I realize that’s all not very satisfactory, but I really can’t offer to do anything more.

@XhmikosR
Copy link
Member

I understand, no worries. The only way moving forward would probably be to deprecate the packages, unless someone automates the whole thing, which I'm not sure it's safe to do so like cutting new releases blindly...

@XhmikosR
Copy link
Member

Now that I think about it, there might be a way to solve this.

We make vnu.jar a peer dependency and cut a new major version. Then each consumer of the package would need to explicitly install vnu.jar themselves, so, as long as there aren't any breaking changes this will probably work.

@sideshowbarker
Copy link
Member Author

Now that I think about it, there might be a way to solve this.

We make vnu.jar a peer dependency and cut a new major version.

That sounds workable, on the face of it.

Then each consumer of the package would need to explicitly install vnu.jar themselves, so, as long as there aren't any breaking changes this will probably work.

For the checker, we don’t really do breaking changes anyway. I mean, it’s an application, not a library — at least it is so in the way grunt-html is using it; it’s not using and API. (And anyway, even if grunt-html were using the API thing that the checker as actually have — we never really have changed that API either.)

And even if I did introduce something that from the grunt-html POV was actually a breaking change — that would almost certainly be an unintended bug, and I could revert the change (and un-break things).

@XhmikosR
Copy link
Member

I'll add it in my TODO list to got the peer dependency way when I have some time and cut a new major version.

Gulp-html should probably be archived since tests are broken for so long and I don't use it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants