fix(isMobilePhone): restrict mk-MK locale to valid mobile numbers only #2579
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
|
could you fix the failed tests as well |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2579 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2535 2535
Branches 641 641
=========================================
Hits 2535 2535 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Macedonian (mk-MK) phone number validation to only accept valid mobile phone numbers, excluding landlines and service numbers. The regex has been simplified to match the specific mobile number formats used in North Macedonia.
- Updated regex pattern to only validate mobile numbers (07x and +3897x formats)
- Replaced comprehensive test cases with focused mobile-only examples
- Moved test case to maintain alphabetical ordering
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/isMobilePhone.js | Updated mk-MK regex to restrict validation to mobile numbers only |
| test/validators.test.js | Replaced test cases with mobile-specific examples and reordered for consistency |
Comments suppressed due to low confidence (1)
test/validators.test.js:10557
- The test case '+38971234567' will fail with the current regex pattern. The regex expects +3897[0-9] but this number has +38971, which doesn't match the pattern.
'+38971234567',
| @@ -161,7 +161,7 @@ const phones = { | |||
| 'ar-YE': /^(((\+|00)9677|0?7)[0137]\d{7}|((\+|00)967|0)[1-7]\d{6})$/, | |||
| 'ar-EH': /^(\+?212|0)[\s\-]?(5288|5289)[\s\-]?\d{5}$/, | |||
| 'fa-AF': /^(\+93|0)?(2{1}[0-8]{1}|[3-5]{1}[0-4]{1})(\d{7})$/, | |||
| 'mk-MK': /^(\+?389|0)?((?:2[2-9]\d{6}|(?:3[1-4]|4[2-8])\d{6}|500\d{5}|5[2-9]\d{6}|7[0-9][2-9]\d{5}|8[1-9]\d{6}|800\d{5}|8009\d{4}))$/, | |||
| 'mk-MK': /^(\+3897[0-9]|07[0-9])[0-9]{6}$/, | |||
There was a problem hiding this comment.
The regex pattern is too restrictive. It only matches numbers starting with +3897 or 07, but according to the test cases, +38971234567 should be valid. The pattern should be /^(+38970[0-9]|070[0-9])[0-9]{6}$/ or adjusted to match the actual mobile number format.
| 'mk-MK': /^(\+3897[0-9]|07[0-9])[0-9]{6}$/, | |
| 'mk-MK': /^(\+3897[1-9][0-9]{6}|07[1-9][0-9]{6})$/, |
Copilot uses AI. Check for mistakes.
Updated the regex for the mk-MK locale to match only valid Macedonian mobile phone numbers.
This excludes landlines (e.g., 02, 03x), toll-free/service numbers (e.g., 800), and other invalid formats.
Supports both national (07x) and international (+3897x) mobile formats.
Includes tests for valid and invalid examples.