Skip to content

Conversation

@21vedansh
Copy link

Updated the Moldova phone validator locale code from ro-MD to correct md-MD

The current locale code for Moldovan phone numbers was wrong, Moldova’s official locale should be represented as md-MD for proper validation and accuracy.

ref: https://en.wikipedia.org/wiki/ISO_3166-1

@WikiRik
Copy link
Member

WikiRik commented Aug 10, 2025

The ICU locale seems to be ro-MD so that's what we use in this project as well; https://www.localeplanet.com/icu/ro-MD/index.html

@WikiRik WikiRik closed this Aug 10, 2025
@21vedansh
Copy link
Author

Thanks for the clarification, @WikiRik. I wasn't aware that the project was standardising on ICU locale codes. I was wondering if we might consider aligning with the ISO convention or is it important that we stick strictly to ICU locales for all validators? Curious to hear your thoughts.

@WikiRik
Copy link
Member

WikiRik commented Aug 11, 2025

@21vedansh the project isn't standardising on anything at the moment. That is something that we should fix in the long term. Many validators are using (ICU) locales, but ISO 3166-1 is often more fitting. That's just from older contributors and maintainers, but changing that does cause a lot of people to update so we're not going to fix it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants