Skip to content

Ensure script runs correctly under /bin/sh (dash) on Ubuntu 22.04 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Ensure script runs correctly under /bin/sh (dash) on Ubuntu 22.04 #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ fi

os_type=$(uname)
MODULE_EXT=".so"
if [[ "$os_type" == "Darwin" ]]; then
if [ "$os_type" = "Darwin" ]; then
MODULE_EXT=".dylib"
elif [[ "$os_type" == "Linux" ]]; then
elif [ "$os_type" = "Linux" ]; then
MODULE_EXT=".so"
else
echo "Unsupported OS type: $os_type"
Expand All @@ -112,7 +112,7 @@ export MODULE_PATH="$SCRIPT_DIR/target/release/libvalkey_bloom$MODULE_EXT"
echo "Running the integration tests..."
if [ ! -z "${ASAN_BUILD}" ]; then
# TEST_PATTERN can be used to run specific tests or test patterns.
if [[ -n "$TEST_PATTERN" ]]; then
if [ -n "$TEST_PATTERN" ]; then
python3 -m pytest --capture=sys --cache-clear -v "$SCRIPT_DIR/tests/" -k $TEST_PATTERN 2>&1 | tee test_output.tmp
else
echo "TEST_PATTERN is not set. Running all integration tests."
Expand Down Expand Up @@ -141,7 +141,7 @@ if [ ! -z "${ASAN_BUILD}" ]; then
rm test_output.tmp
else
# TEST_PATTERN can be used to run specific tests or test patterns.
if [[ -n "$TEST_PATTERN" ]]; then
if [ -n "$TEST_PATTERN" ]; then
python3 -m pytest --cache-clear -v "$SCRIPT_DIR/tests/" -k $TEST_PATTERN
else
echo "TEST_PATTERN is not set. Running all integration tests."
Expand Down