[Python] Fix flaky test test_sync_pubsub_exact_happy_path
#5057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hank95179
force-pushed
the
fix-issue-4970-sync-pubsub
branch
2 times, most recently
from
021cd7d to
f617809
Compare
xShinnRyuu
reviewed
Dec 12, 2025
…ient creation Signed-off-by: hank95179 <[email protected]>
hank95179
force-pushed
the
fix-issue-4970-sync-pubsub
branch
from
f617809 to
15daa40
Compare
yipin-chen
changed the title
test_sync_pubsub_exact_happy_path #4970test_sync_pubsub_exact_happy_path
xShinnRyuu
approved these changes
Jan 5, 2026
affonsov
approved these changes
Jan 5, 2026
tdschwarz
pushed a commit
to tdschwarz/valkey-glide
that referenced
this pull request
Jan 9, 2026
…o#5057) Fix flaky test valkey-io#4970: Add retry mechanism for Sync PubSub client creation Signed-off-by: hank95179 <[email protected]> Co-authored-by: Thomas Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #4970
Description
This PR addresses the flakiness observed in
TestSyncPubSub.test_sync_pubsub_exact_happy_path.In high-load environments (e.g., CI/CD), initializing two synchronous clients simultaneously occasionally results in a
ClosingError: connection attempt timed out.Solution
Implemented a retry mechanism in
tests/sync_tests/test_sync_pubsub.py.create_two_clients_with_pubsubcall in a retry loop.Verification
Verified that the test is more resilient to resource contention and transient network delays during client creation.