Fix/node zscan assertion logic #5144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the zscan test in SharedTests.ts to allow keys from 'charMembers' (e.g., 'a', 'b', etc.) in the scan results. Previously, the test strictly asserted that all returned keys must start with 'member', causing intermittent failures when 'charMembers' were encountered during scanning (Issue #4814). Signed-off-by: hank95179 <[email protected]>
Collaborator
Author
|
This PR is an updated version of #5065. Refer to the comment history of that task for details. |
xShinnRyuu
requested review from
currantw,
jamesx-improving,
jduo and
yipin-chen
currantw
reviewed
Jan 9, 2026
Signed-off-by: Thomas Zhou <[email protected]>
xShinnRyuu
force-pushed
the
fix/issue-4814-zscan-flake
branch
from
17445cf to
5dc62e7
Compare
xShinnRyuu
force-pushed
the
fix/issue-4814-zscan-flake
branch
from
a360f47 to
5dc62e7
Compare
xShinnRyuu
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an updated version of #5065 from @hank95179. Thank you for your contribution.
Description
This PR addresses the flakiness observed in the zscan test within
node/tests/SharedTests.ts.The test seeds the database with two sets of data: charMembers (e.g., 'a', 'b', 'c') and members (e.g., 'member 1', 'member 2'...).
The previous assertion strictly required all items returned by zscan to start with "member". However, zscan iterates through the set and may correctly return items from charMembers. When this happened, the strict assertion caused the test to fail incorrectly.
Solution
Updated the logic of zscan to only match results starting with
memberIssue link
This Pull Request is linked to issue (URL): [Node][Flaky Test] GlideClient › zscan test_x #4814
Checklist
Before submitting the PR make sure the following are checked:
CHANGELOG.md and documentation files are updated.