Fix/python issue 4952 zscan for no_scores option #5149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilures This change increases the timeout from 50s to 120s in TlsCertificateTest.test.ts. This prevents 'Exceeded timeout of 50000 ms for a hook' errors during cluster creation on slower environments, addressing Issue #4989. Signed-off-by: hank95179 <[email protected]>
…g with value Signed-off-by: Thomas Zhou <[email protected]>
xShinnRyuu
force-pushed
the
fix/python-issue-4952-zscan
branch
from
75df4a1 to
5588cd0
Compare
Collaborator
Author
|
Duplicate of: #5056 |
xShinnRyuu
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
xShinnRyuu
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an updated version of #5056 from @hank95179. Thank you for your contribution.
Description
This PR addresses the flakiness observed in
test_zscanandtest_sync_zscan.The test seeds the database with two sets of data: a
char_map(keys: 'a', 'b', 'c'...) and a largenum_map(keys: 'value 0', 'value 1'...).The previous assertion strictly required all items returned by
zscanto start with"value". However, sincezscaniterates through the set, it occasionally returns items from thechar_map. When this happened, the strict assertion caused the test to fail incorrectly.Solution
Updated the logic of zscan to only match results starting with
valueIssue link
This Pull Request is linked to issue (URL): [Python][Flaky Test] TestClusterRoutes > test_zscan & test_sync_zscan #4952
Checklist
Before submitting the PR make sure the following are checked:
CHANGELOG.md and documentation files are updated.