Switch to check spelling #234
Open
+2,668
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
requested review from
ahmedsobeh,
bogdanp05,
mkmkme and
smeso
as code owners
Replaces rojopolis/spellcheck-github-actions Signed-off-by: Josh Soref <[email protected]>
jsoref
force-pushed
the
switch-to-check-spelling
branch
from
d81d882 to
cd54f9d
Compare
jsoref
commented
Oct 20, 2025
| assert await decoded_r.bf().card("bf1") == 1 | ||
|
|
||
| # Error when key is of a type other than Bloom filtedecoded_r. | ||
| # Error when key is of a type other than Bloom filter decoded_r. |
|
|
||
| @skip_if_server_version_lt("6.2.0") | ||
| def test_zrandemember(self, r): | ||
| def test_zrandmember(self, r): |
|
|
||
| def parse_item(item): | ||
| result = {"id": item[0], "start_time": int(item[1]), "duration": int(item[2])} | ||
| # Valkey Enterprise injects another entry at index [3], which has |
There was a problem hiding this comment.
Personally I was more bothered by Valkey Enterprise:
https://valkey-oss-developer.slack.com/archives/C06RQ5P6QPL/p1760984702515739
Comment on lines
-395
to
+396
| # the complexity info (i.e. the value N in case the command has | ||
| # an O(N) complexity) instead of the command. | ||
| # the complexity info (i.e. the value N for a command of complexity | ||
| # O(N)) instead of the command. |
There was a problem hiding this comment.
check-spelling/spell-check-this didn't like in case (and I agree)
|
|
||
| def _check_certificate(issuer_cert, ocsp_bytes, validate=True): | ||
| """A wrapper the return the validity of a known ocsp certificate""" | ||
| """A wrapper to return the validity of a known ocsp certificate""" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Description of change
Normally, I wouldn't bundle spelling fixes and the workflow, but my previous change unfortunately broke the other spell checker, so...