Add response types for KEYS and SCAN commands #244
+35
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natan Rolnik <[email protected]>
natanrolnik
force-pushed
the
scan-response
branch
from
aafc50e to
785b46d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage ? 39.51%
=======================================
Files ? 93
Lines ? 15721
Branches ? 0
=======================================
Hits ? 6212
Misses ? 9509
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
freak4pc
reviewed
Oct 10, 2025
| ```swift | ||
| let valkeyClient = ValkeyClient(.hostname("localhost", port: 6379), logger: logger) | ||
| try await withThrowingTaskgroup(of: Void.self) { group in | ||
| try await withThrowingTaskGroup(of: Void.self) { group in |
There was a problem hiding this comment.
:chefs-kiss:
Suggested change
| try await withThrowingTaskGroup(of: Void.self) { group in | |
| try await withThrowingDiscardingTaskGroup { group in |
adam-fowler
reviewed
Oct 10, 2025
| public let keys: [ValkeyKey] | ||
|
|
||
| public init(fromRESP token: RESPToken) throws { | ||
| let (cursor, keys) = try token.decodeArrayElements(as: (Int, [ValkeyKey]).self) |
There was a problem hiding this comment.
You can use (self.cursor, self.keys) = .... You don't need the temporary variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a sample project, I found it was really hard to parse the response of the
SCANandKEYScommands.After talking to @adam-fowler, he told me about the
RESPTokenDecodableprotocol, which makes it really easy to implement type safe responses, so I added them.