Update dual channel replication conf to mention the local buffer is imited by COB #2824
Conversation
…imited by COB After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2824 +/- ##
============================================
- Coverage 72.47% 72.44% -0.03%
============================================
Files 128 128
Lines 70286 70300 +14
============================================
- Hits 50937 50930 -7
- Misses 19349 19370 +21
🚀 New features to boost your workflow:
|
JimB123
left a comment
JimB123
left a comment
There was a problem hiding this comment.
Looks like a good documentation and logging change.
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Is dual-channel replication documented in any other place than in the template config file?
I don't think the config comments is the best place to put a lot of documentation. I think we need dual channel replication docs in the doc repo in topics/replication.md.
I don't think so. @naglera do we have a dual channel replication doc in the valkey-doc repo? It seems we didn't write it?
We can document it in two places. One is complex and detailed, and the other is simple (which can be redirected to the complex one). As far as I know, very few people actually read the documentation, and many don't even look at the valkey.conf configuration file. |
…mited by COB (valkey-io#2824) After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]>
…mited by COB (valkey-io#2824) After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]>
…mited by COB (valkey-io#2824) After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]>
4 participants
After introducing the dual channel replication in #60, we decided in #915
not to add a new configuration item to limit the replica's local replication
buffer, just use "client-output-buffer-limit replica hard" to limit it.
We need to document this behavior and mention that once the limit is reached,
all future data will accumulate in the primary side.