-
Notifications
You must be signed in to change notification settings - Fork 955
Fix timing issue in dual channel replication COB test #2847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After valkey-io#2829, valgrind report a test failure, it seems that the time is not enough to generate a COB limit in valgrind. Signed-off-by: Binbin <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2847 +/- ##
============================================
+ Coverage 72.26% 72.49% +0.22%
============================================
Files 128 128
Lines 70370 70371 +1
============================================
+ Hits 50851 51013 +162
+ Misses 19519 19358 -161 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If 5 seconds is not enough in our valgrind builds, maybe it's not enough in some real scenarios too? Should we increase the default to 10 seconds?
This is actually a test dependency, in real wordl scenarios, servers that slow seem unlikely. It can't even generate 1100k of traffic in 5 seconds. |
|
OK |
After valkey-io#2829, valgrind report a test failure, it seems that the time is not enough to generate a COB limit in valgrind. Signed-off-by: Binbin <[email protected]>
After valkey-io#2829, valgrind report a test failure, it seems that the time is not enough to generate a COB limit in valgrind. Signed-off-by: Binbin <[email protected]>
After valkey-io#2829, valgrind report a test failure, it seems that the time is not enough to generate a COB limit in valgrind. Signed-off-by: Binbin <[email protected]>
After #2829, valgrind report a test failure, it seems that the time is not enough to generate a COB limit in valgrind.