Skip to content

Conversation

@enjoy-binbin
Copy link
Member

After #2829, valgrind report a test failure, it seems that the time is not enough to generate a COB limit in valgrind.

After valkey-io#2829, valgrind report a test failure, it seems that
the time is not enough to generate a COB limit in valgrind.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin
Copy link
Member Author

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.49%. Comparing base (86db609) to head (7bb3af9).
⚠️ Report is 2 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2847      +/-   ##
============================================
+ Coverage     72.26%   72.49%   +0.22%     
============================================
  Files           128      128              
  Lines         70370    70371       +1     
============================================
+ Hits          50851    51013     +162     
+ Misses        19519    19358     -161     

see 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 5 seconds is not enough in our valgrind builds, maybe it's not enough in some real scenarios too? Should we increase the default to 10 seconds?

@enjoy-binbin
Copy link
Member Author

If 5 seconds is not enough in our valgrind builds, maybe it's not enough in some real scenarios too? Should we increase the default to 10 seconds?

This is actually a test dependency, in real wordl scenarios, servers that slow seem unlikely. It can't even generate 1100k of traffic in 5 seconds.
$primary config set client-output-buffer-limit "replica 1100k 0 0"

@zuiderkwast
Copy link
Contributor

OK

@enjoy-binbin enjoy-binbin merged commit aef56e5 into valkey-io:unstable Nov 17, 2025
56 checks passed
@enjoy-binbin enjoy-binbin deleted the fix_timing_test branch November 17, 2025 09:25
zhijun42 pushed a commit to zhijun42/valkey that referenced this pull request Nov 28, 2025
After valkey-io#2829, valgrind report a test failure, it seems that the time is
not enough to generate a COB limit in valgrind.

Signed-off-by: Binbin <[email protected]>
zhijun42 pushed a commit to zhijun42/valkey that referenced this pull request Nov 28, 2025
After valkey-io#2829, valgrind report a test failure, it seems that the time is
not enough to generate a COB limit in valgrind.

Signed-off-by: Binbin <[email protected]>
zhijun42 pushed a commit to zhijun42/valkey that referenced this pull request Nov 28, 2025
After valkey-io#2829, valgrind report a test failure, it seems that the time is
not enough to generate a COB limit in valgrind.

Signed-off-by: Binbin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants