Allow fetching server info with NULL context, add other server info getters#224
Open
PDXKimani wants to merge 2 commits intovalkey-io:mainfrom
Open
Allow fetching server info with NULL context, add other server info getters#224PDXKimani wants to merge 2 commits intovalkey-io:mainfrom
PDXKimani wants to merge 2 commits intovalkey-io:mainfrom
Conversation
Signed-off-by: Dylan Abraham <dylan@momentohq.com>
PDXKimani
force-pushed
the
contextless-server-info
branch
from
a0785bb to
d3d7737
Compare
Signed-off-by: Dylan Abraham <dylan@momentohq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My understanding of the underlying C module API is that we're allowed to make these ServerInfo calls with a null context. This should be safe in Rust, since we're already ensuring that Free is called via Drop implementations and shouldn't need to rely on auto memory management via contexts. This change would allow modules to poll server info without having to lock a context (e.g. for background metrics collection).
This change also includes access to the other server info field APIs.