Skip to content

- Implement of promise for filter function; - #1105

Open
duykhang53 wants to merge 7 commits into
valor-software:developmentfrom
duykhang53:development
Open

- Implement of promise for filter function;#1105
duykhang53 wants to merge 7 commits into
valor-software:developmentfrom
duykhang53:development

Conversation

@duykhang53

Copy link
Copy Markdown

File filter function from this commit now can be resolved from both boolean and Promise<boolean>

@codecov

codecov Bot commented Sep 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1105 into development will increase coverage by 0.19%.
The diff coverage is 28.94%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1105      +/-   ##
===============================================
+ Coverage        34.72%   34.91%   +0.19%     
===============================================
  Files               10       10              
  Lines              550      547       -3     
  Branches            80       83       +3     
===============================================
  Hits               191      191              
+ Misses             341      336       -5     
- Partials            18       20       +2
Impacted Files Coverage Δ
src/file-upload/file-uploader.class.ts 24.63% <11.53%> (+0.44%) ⬆️
src/file-upload/file-drop.directive.ts 60% <62.5%> (-1.23%) ⬇️
src/file-upload/file-select.directive.ts 73.91% <75%> (-3.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb48f44...1e5fb25. Read the comment docs.

@angus151

Copy link
Copy Markdown

Can we get this pulled?

@duykhang53

Copy link
Copy Markdown
Author

Yea sure

@angus151

Copy link
Copy Markdown

Yea sure

Sorry, comment wasn't direct at you, but to hopefully catch the eye of one of the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants