Skip to content

chore(deps): migrate @th3rdwave/react-navigation-bottom-sheet to the @interaxyz fork#6468

Merged
bakoushin merged 2 commits intomainfrom
alex/react-navigation-bottom-sheet
Jan 31, 2025
Merged

chore(deps): migrate @th3rdwave/react-navigation-bottom-sheet to the @interaxyz fork#6468
bakoushin merged 2 commits intomainfrom
alex/react-navigation-bottom-sheet

Conversation

@bakoushin
Copy link
Contributor

Description

Migrate @th3rdwave/react-navigation-bottom-sheet to @interaxyz fork in order to get rid of the patch.

The patch changes are implemented in the fork:
AppAndFlow/react-navigation-bottom-sheet@main...interaxyz:react-navigation-bottom-sheet:intera-fork

TODO

Migrate back to the original package once AppAndFlow/react-navigation-bottom-sheet#26 is released.

Test plan

  • CI
  • Manually tested on Android/iOS emulators (WalletConnect request)

Related issues

Backwards compatibility

Y

Network scalability

NA

Copy link
Contributor

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bakoushin bakoushin enabled auto-merge January 31, 2025 15:37
@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (b0acd29) to head (47da676).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6468      +/-   ##
==========================================
- Coverage   89.05%   89.04%   -0.01%     
==========================================
  Files         730      730              
  Lines       31890    31890              
  Branches     6107     5792     -315     
==========================================
- Hits        28400    28397       -3     
- Misses       3293     3446     +153     
+ Partials      197       47     -150     
Files with missing lines Coverage Δ
src/dapps/DappShortcutTransactionRequest.tsx 95.50% <ø> (ø)
.../fiatExchanges/FiatExchangeCurrencyBottomSheet.tsx 93.44% <ø> (ø)

... and 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0acd29...47da676. Read the comment docs.

@bakoushin bakoushin added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@bakoushin bakoushin added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 4776edd Jan 31, 2025
15 checks passed
@bakoushin bakoushin deleted the alex/react-navigation-bottom-sheet branch January 31, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments