Client connection cleaner

[chhquan]

Client and HostClient register itself to cleaner to clean resource, instead of creating a goroutine. new interface resourceClean will help a client to clean resource. Client implements resourceClean can register to the global cleaner.

[moredure]

I love this idea

[moredure]

@chhquan Maybe change this

func (c *Client) hasResource() bool {
	c.mLock.Lock()
	defer c.mLock.Unlock()
	if len(c.m) > 0 || len(c.ms) > 0 {
		return true
	}
	return false
}

to this

func (c *Client) hasResource() bool {
	c.mLock.Lock()
	defer c.mLock.Unlock()
	return len(c.m) > 0 || len(c.ms) > 0
}

[moredure]

And in case !c.connsCleanerRun && !connectionClose new connection is connectionClosed we do not need to count it as a connection, maybe since we should no register such a connections in connectionsCleaner and in some cases if all connections across fasthttp.Client will be connectionClosed, maybe we don't need connectionsCleaner goroutine running.

[moredure]

I mean replace this

if c.connsCount == 1 {
    startCleaner = true
}

maybe with this, not sure regarding connectionCounting maybe skip increasing connection counter in case connectionClose

if c.connsCount > 0 && !connectionClose {
    startCleaner = true
}

to avoid creating connectionCleaner for one_time_requests-only client

[erikdubbelboer]

Suggested change

// Store client

The statement below is already super clear, it doesn't need a comment like this.

[erikdubbelboer]

Suggested change

// Check if init

Not really a check and not really a needed comment.

[erikdubbelboer]

What is this slice for? Merge the loops below so this isn't needed anymore.

[erikdubbelboer]

Maybe call it cleanableClient? Either you use resource everywhere and make it all generic. Or use client and make it specific for clients.

[tylitianrui]

it can avoid mutex . sync.Once is implemented by Mutex

[tylitianrui]

I think if atomic.CompareAndSwapUint32(&o.done, 0, 1) ) is better

clientCleaner

type clientCleaner struct {
	done       int32
	// clients to clean
	clients        sync.Map
}

method init:

func (c *clientCleaner) init() {
	if atomic.CompareAndSwapUint32(&o.done, 0, 1) {
               go c.cleaner()
}

[erikdubbelboer]

Good catch, sync.Once is only really needed if what you are doing inside it is really required for the rest of the code to continue. This is not the case here, it's perfectly fine if the goroutine is started after calls to register have completed already.

[chhquan]

@moredure @erikdubbelboer @tylitianrui ok! i will change the code for your suggestion.

[moredure]

simplify return len(c.m) > 0 || len(c.ms) > 0