Skip to content

Commit 8b9ca6a

Browse files
authored
Use node 22 in repo, test against node 20 and .nvmrc version (currently 22.15.0) (#1577)
1 parent 1b34bb5 commit 8b9ca6a

File tree

4 files changed

+129
-117
lines changed

4 files changed

+129
-117
lines changed

.github/workflows/validate.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ jobs:
88
matrix:
99
# Blank string allows us to test against version in nvmrc file
1010
# configured in 'Set up Node.js' down below.
11-
node: ['', 'lts/*']
12-
name: Lint & Test (${{ (matrix.node && matrix.node != 'lts/*') && format('node {0}', matrix.node) || matrix.node || 'nvmrc' }})
11+
node: ['20', '']
12+
name: Lint & Test (${{ (matrix.node && matrix.node != '20') && format('node {0}', matrix.node) || matrix.node || 'nvmrc' }})
1313
runs-on: ubuntu-latest
1414
env:
1515
CI: true
@@ -42,8 +42,8 @@ jobs:
4242
matrix:
4343
# Blank string allows us to test against version in nvmrc file
4444
# configured in 'Set up Node.js' down below.
45-
node: ['', 'lts/*']
46-
name: Windows Tests (${{ (matrix.node && matrix.node != 'lts/*') && format('node {0}', matrix.node) || matrix.node || 'nvmrc' }})
45+
node: ['20', '']
46+
name: Windows Tests (${{ (matrix.node && matrix.node != '20') && format('node {0}', matrix.node) || matrix.node || 'nvmrc' }})
4747
runs-on: windows-latest
4848
env:
4949
CI: true

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v20.9.0
1+
22.15.0

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"@preconstruct/cli": "^2.8.2",
4141
"@testing-library/jest-dom": "^6.4.2",
4242
"@types/jest": "^29.5.12",
43-
"@types/node": "^20.9.5",
43+
"@types/node": "^22.15.3",
4444
"@vanilla-extract/jest-transform": "workspace:*",
4545
"babel-jest": "^29.7.0",
4646
"cross-env": "^7.0.3",

0 commit comments

Comments
 (0)