Don't apply the plugin for Android test projects (#130)

Author: vRallev

src/main/groovy/com/vanniktech/android/junit/jacoco/GenerationPlugin.groovy

@@ -44,18 +44,16 @@ class GenerationPlugin implements Plugin<Project> {
     protected static boolean addJacoco(final Project subProject, final JunitJacocoExtension extension, JacocoMerge mergeTask, JacocoReport mergedReportTask) {
         if (!shouldIgnore(subProject, extension)) {
             if (isAndroidProject(subProject)) {
-                addJacocoAndroid(subProject, extension, mergeTask, mergedReportTask)
-                return true
+                return addJacocoAndroid(subProject, extension, mergeTask, mergedReportTask)
             } else if (isJavaProject(subProject)) {
-                addJacocoJava(subProject, extension, mergeTask, mergedReportTask)
-                return true
+                return addJacocoJava(subProject, extension, mergeTask, mergedReportTask)
             }
         }
 
         return false
     }
 
-    private static void addJacocoJava(final Project subProject, final JunitJacocoExtension extension, JacocoMerge mergeTask, JacocoReport mergedReportTask) {
+    private static boolean addJacocoJava(final Project subProject, final JunitJacocoExtension extension, JacocoMerge mergeTask, JacocoReport mergedReportTask) {
         subProject.plugins.apply('jacoco')
 
         subProject.jacoco {
@@ -103,9 +101,10 @@ class GenerationPlugin implements Plugin<Project> {
         }
 
         subProject.check.dependsOn 'jacocoTestReport'
+        return true
     }
 
-    private static void addJacocoAndroid(final Project subProject, final JunitJacocoExtension extension, JacocoMerge mergeTask, JacocoReport mergedReportTask) {
+    private static boolean addJacocoAndroid(final Project subProject, final JunitJacocoExtension extension, JacocoMerge mergeTask, JacocoReport mergedReportTask) {
         subProject.plugins.apply('jacoco')
 
         subProject.jacoco {
@@ -119,8 +118,12 @@ class GenerationPlugin implements Plugin<Project> {
         Collection<BaseVariant> variants = []
         if (isAndroidApplication(subProject)) {
             variants = subProject.android.applicationVariants
-        } else {
+        } else if (isAndroidLibrary(subProject) || isAndroidFeature(subProject)) {
+            // FeatureExtension extends LibraryExtension
             variants = subProject.android.libraryVariants
+        } else {
+            // test plugin or something else
+            return false
         }
 
         variants.all { variant ->
@@ -213,6 +216,8 @@ class GenerationPlugin implements Plugin<Project> {
 
             subProject.check.dependsOn "${taskName}"
         }
+
+        return true
     }
 
     private static addJacocoMergeToRootProject(final Project project, final JunitJacocoExtension extension) {
@@ -316,6 +321,14 @@ class GenerationPlugin implements Plugin<Project> {
         return project.plugins.hasPlugin('com.android.application')
     }
 
+    protected static boolean isAndroidLibrary(final Project project) {
+        return project.plugins.hasPlugin('com.android.library')
+    }
+
+    protected static boolean isAndroidFeature(final Project project) {
+        return project.plugins.hasPlugin('com.android.feature')
+    }
+
     private static boolean shouldIgnore(final Project project, final JunitJacocoExtension extension) {
         if (extension.ignoreProjects?.contains(project.name) || extension.ignoreProjects?.contains(project.path)) {
             // Regex could be slower.

src/test/groovy/com/vanniktech/android/junit/jacoco/GenerationTest.groovy

@@ -43,6 +43,19 @@ class GenerationTest {
         assertJacocoAndroidWithoutFlavors(androidLibraryProject)
     }
 
+    @Test void addJacocoAndroidFeature() {
+        def androidLibraryProject = ProjectHelper.prepare(ANDROID_FEATURE).get()
+
+        GenerationPlugin.addJacoco(androidLibraryProject, new JunitJacocoExtension())
+
+        assertJacocoAndroidWithoutFlavors(androidLibraryProject)
+    }
+
+    @Test void addJacocoAndroidTest() {
+        def androidTestProject = ProjectHelper.prepare(ANDROID_TEST).get()
+        assert !GenerationPlugin.addJacoco(androidTestProject, new JunitJacocoExtension())
+    }
+
     @Test void addJacocoJava() {
         def javaProject = ProjectHelper.prepare(JAVA).get()
 

src/test/groovy/com/vanniktech/android/junit/jacoco/ProjectHelper.groovy

@@ -2,6 +2,7 @@ package com.vanniktech.android.junit.jacoco
 
 import com.android.build.gradle.AppExtension
 import com.android.build.gradle.LibraryExtension
+import com.android.build.gradle.TestExtension
 import com.android.build.gradle.api.BaseVariant
 import com.android.builder.model.BuildType
 import groovy.mock.interceptor.MockFor
@@ -46,6 +47,7 @@ final class ProjectHelper {
                 project.android.applicationVariants.metaClass.all = { delegate.each(it) }
                 break
             case ProjectType.ANDROID_LIBRARY:
+            case ProjectType.ANDROID_FEATURE:
                 project = ProjectBuilder.builder().withName('android library').build()
                 def androidMock = new MockFor(LibraryExtension)
                 def buildTypesMock = ["debug", "release"].collect { bt ->
@@ -66,6 +68,12 @@ final class ProjectHelper {
                 // mock .all{ } function from android gradle lib with standard groovy .each{ }
                 project.android.libraryVariants.metaClass.all = { delegate.each(it) }
                 break
+            case ProjectType.ANDROID_TEST:
+                project = ProjectBuilder.builder().withName('android test').build()
+                def androidMock = new MockFor(TestExtension)
+                androidMock.metaClass.testOptions = null
+                project.metaClass.android = androidMock
+                break
         }
 
         project.plugins.apply(projectType.pluginName)
@@ -103,6 +111,7 @@ final class ProjectHelper {
                 project.android.applicationVariants.metaClass.all = { delegate.each(it) }
                 break
             case ProjectType.ANDROID_LIBRARY:
+            case ProjectType.ANDROID_FEATURE:
                 project.android.metaClass.libraryVariants = variants
                 // mock .all{ } function from android gradle lib with standard groovy .each{ }
                 project.android.libraryVariants.metaClass.all = { delegate.each(it) }
@@ -119,6 +128,8 @@ final class ProjectHelper {
     enum ProjectType {
         ANDROID_APPLICATION('com.android.application'),
         ANDROID_LIBRARY('com.android.library'),
+        ANDROID_FEATURE('com.android.feature'),
+        ANDROID_TEST('com.android.test'),
         JAVA('java')
 
         private final String pluginName