Extended mapping to node attributes #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'll take a look later today! |
vanniktech
approved these changes
May 19, 2025
Owner
vanniktech
left a comment
vanniktech
left a comment
There was a problem hiding this comment.
This looks really good. Regarding configuration cache, I'd love to have it but I have limited time available and can't dedicate much time here. I will always review PRs though!
| when { | ||
| dependency.moduleName.contains("x") -> BasicNodeType("#ABC123", Shape.EGG) | ||
| dependency.moduleName.contains("k") -> BasicNodeType("#DEF789", Shape.POINT) | ||
| // !dependency.moduleGroup.contains("kotlin") -> BasicNodeType("#000000", Shape.OCTAGON) |
Contributor
Author
There was a problem hiding this comment.
Ah yeah, forgot about that. Removed
Contributor
Author
|
Awesome, I'll have a mess around and see what I can come up with! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was the
ProjectTargetenum to identify a project type based on the applied plugins, which is nice but I wanted to add some extra logic beyond just the plugin IDs for selecting these - plus the option for different node types.So I've mapped it into a more generic config option for both graph types, along with typealiases to make it a bit easier to work with.
Also added the same for dependency node types - with a null default implementation alongside an optional implementation which does a dumb check on the hash of the dependency group to come up with a common colour.
❓ Side question ❓
I've been poking around the repo trying to get it to work nicely with Gradle's configuration cache - I think it's doable but it will probably mean a significant project rework. Would you rather I did that separately on my fork?