Enforced 9-digit phone number format after country code +254 (Kenya)#432
Open
Naymbura wants to merge 6 commits intovanshg395:masterfrom
Open
Enforced 9-digit phone number format after country code +254 (Kenya)#432Naymbura wants to merge 6 commits intovanshg395:masterfrom
Naymbura wants to merge 6 commits intovanshg395:masterfrom
Conversation
added 6 commits
April 29, 2025 14:45
…ountry code is selected
…their contact with 0 resulting to 10 digits while others choose 7 or 1 omitting 0 resulting to 9 digits which are both correct
…gth of 9 and max length of 10
…r 10 digits long for Kenya (while maintaining the existing behavior for other countries)
…ya's minLength: 9, maxLength: 10) as it retains the original behavior for other countries (checks exact min or max length).
…ng both 9 and 10 digits for Kenya, we need to modify both the validator and the maxLength logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated phone number validation to ensure that after selecting the country code +254, users must enter a 9-digit number starting with 7 (e.g., 712345678). This aligns with Kenyan dialing conventions, where users typically omit the leading 0 when the country code is already provided.