Skip to content

Feature/translation EN > ES jwt.es.md file#1036

Merged
TheHandyOwl merged 6 commits intovapor:mainfrom
TheHandyOwl:feature/translation_EN_ES_jwt.es.md
Jan 14, 2025
Merged

Feature/translation EN > ES jwt.es.md file#1036
TheHandyOwl merged 6 commits intovapor:mainfrom
TheHandyOwl:feature/translation_EN_ES_jwt.es.md

Conversation

@TheHandyOwl
Copy link
Contributor

NEW: translation EN (current jwt.md file) to ES (new jwt.es.md file)

@TheHandyOwl TheHandyOwl requested review from a team, 0xTim and gwynne as code owners December 14, 2024 23:11
@TheHandyOwl TheHandyOwl added the translation-update This PR contains translations for the docs label Dec 14, 2024
@TheHandyOwl TheHandyOwl self-assigned this Dec 14, 2024
@TheHandyOwl
Copy link
Contributor Author

TheHandyOwl commented Dec 14, 2024

@0xTim , @gwynne , should this HMAC options be 256, 384 and 512?
I can create another pull request to change this option for all languages.

### HMAC

HMAC (Hash-based Message Authentication Code) is a symmetric algorithm that uses a secret key to sign and verify the JWT. Vapor supports the following HMAC algorithms:

- `HS256`: HMAC with SHA-256
- `HS384`: HMAC with SHA-384
- `HS384`: HMAC with SHA-384 // Should be `HS512`: HMAC with SHA-512?

@alemohamad
Copy link
Member

Good catch @TheHandyOwl ! In my opinion, we should add the fix in other languages in this PR.

@0xTim @gwynne what do you think?

@0xTim
Copy link
Member

0xTim commented Dec 17, 2024

Yep lets do it as part of this PR since it's related

Copy link
Member

@alemohamad alemohamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, and then merge it. 👍

@TheHandyOwl TheHandyOwl requested a review from a team January 14, 2025 22:22
@TheHandyOwl TheHandyOwl enabled auto-merge (squash) January 14, 2025 22:22
@alemohamad alemohamad force-pushed the feature/translation_EN_ES_jwt.es.md branch from f847c25 to 806e54e Compare January 14, 2025 22:31
@TheHandyOwl TheHandyOwl merged commit 21903c4 into vapor:main Jan 14, 2025
1 check passed
@TheHandyOwl TheHandyOwl deleted the feature/translation_EN_ES_jwt.es.md branch January 14, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation-update This PR contains translations for the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants