Skip to content

Fix a race condition in testCopyFromHasWriteBackpressure #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabianfett merged 2 commits into from
Dec 19, 2025
Merged

Fix a race condition in testCopyFromHasWriteBackpressure #614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c721c96
Fix a race condition in `testCopyFromHasWriteBackpressure`
ahoppen Dec 18, 2025
f3d1fa5
Merge branch 'main' into backpressure-test-race
fabianfett Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Tests/PostgresNIOTests/New/PostgresConnectionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,9 +873,22 @@ import Synchronization
} preCopyInResponse: { channel in
channel.isWritable = false
} mockBackend: { channel, _ in
// The `writeData` closure is executed on a background task. Ensure it started executing before we proceed
// with the backend mock. This typically doesn't enter the retry loop at all.
var isWritingReloadCounter = 0
while !isWriting.load(ordering: .sequentiallyConsistent), isWritingReloadCounter < 100 {
try await Task.sleep(for: .milliseconds(10))
isWritingReloadCounter += 1
}
let isWriting = isWriting.load(ordering: .sequentiallyConsistent)
#expect(isWriting)

// Wait for another 10ms to ensure the `writer.write` call did indeed start and tried to write data, just
// being blocked on the backpressure.
try await Task.sleep(for: .milliseconds(10))

// Now that we know `writeData` is blocked, relieve the write backpressure and check that the copy operation
// finishes.
channel.isWritable = true
channel.pipeline.fireChannelWritabilityChanged()

Expand Down