Skip to content

Conversation

@adam-fowler
Copy link
Contributor

This should only create additional connections if we don't have the minimum number of connections or the number of available plus leased streams and the number of incoming connections is less than the size of the request queue.

Previously we did not take into account the number of incoming connections, which meant we would create additional connections. This does not solve the issue where incoming connections will server more than one request though.

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.08%. Comparing base (98c87ef) to head (6ce9061).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   76.19%   76.08%   -0.12%     
==========================================
  Files         134      134              
  Lines       10145    10147       +2     
==========================================
- Hits         7730     7720      -10     
- Misses       2415     2427      +12     
Files with missing lines Coverage Δ
...ources/ConnectionPoolModule/PoolStateMachine.swift 89.49% <100.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fabianfett fabianfett merged commit 89d9f72 into vapor:main Dec 19, 2025
10 checks passed
@fabianfett fabianfett added the semver-patch No public API change. label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants