Skip to content

add any to protocol#223

Merged
gwynne merged 3 commits intovapor:mainfrom
zunda-pixel:add-any-for-protocol
Sep 8, 2025
Merged

add any to protocol#223
gwynne merged 3 commits intovapor:mainfrom
zunda-pixel:add-any-for-protocol

Conversation

@zunda-pixel
Copy link
Contributor

@zunda-pixel zunda-pixel commented Aug 31, 2025

These changes are now available in 4.13.1

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you enable the existential any flag in the manifest to go along with this?

@zunda-pixel
Copy link
Contributor Author

Hi @0xTim I added .enableUpcomingFeature("ExistentialAny") in Package.swift

@zunda-pixel zunda-pixel requested a review from 0xTim September 1, 2025 05:19
@0xTim
Copy link
Member

0xTim commented Sep 8, 2025

@gwynne do we need to do a big CI overhaul on this package?

@gwynne
Copy link
Member

gwynne commented Sep 8, 2025

Nah, just one tweak. I'll take care of it in a bit.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.33%. Comparing base (b452702) to head (a8fd62c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Redis/Redis+Cache.swift 25.00% 3 Missing ⚠️
Sources/Redis/Application+Redis.swift 66.66% 1 Missing ⚠️
Sources/Redis/Application.Redis+PubSub.swift 0.00% 1 Missing ⚠️
Sources/Redis/Request+Redis.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   53.33%   53.33%           
=======================================
  Files          11       11           
  Lines         420      420           
=======================================
  Hits          224      224           
  Misses        196      196           
Files with missing lines Coverage Δ
Sources/Redis/RedisStorage.swift 62.65% <100.00%> (ø)
Sources/Redis/Application+Redis.swift 41.46% <66.66%> (ø)
Sources/Redis/Application.Redis+PubSub.swift 0.00% <0.00%> (ø)
Sources/Redis/Request+Redis.swift 38.46% <50.00%> (ø)
Sources/Redis/Redis+Cache.swift 72.72% <25.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gwynne gwynne added the semver-patch Internal changes only label Sep 8, 2025
@gwynne gwynne merged commit d822288 into vapor:main Sep 8, 2025
11 checks passed
@zunda-pixel zunda-pixel deleted the add-any-for-protocol branch September 8, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Internal changes only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants