Skip to content

Conversation

@nigoroll
Copy link
Member

For the common cases, the generic and versatile syntax is really cumbersome.

Why exactly did we not add these earlier?

@simonvik
Copy link
Contributor

simonvik commented Jan 15, 2025

Could it be worth writing somewhere that blob.urldecode might be unsafe and truncate values if the url contains %00? (if thats the case)

@nigoroll
Copy link
Member Author

@simonvik good point.
Are there any established alternatives to handling %00 like throwing an error?
If yes, I think we should rather review any IDENTITY encoding to STRING.

@nigoroll nigoroll changed the title vmod_blob: Add convencience functions for urldecode and urlencode vmod_blob: Add convenience functions for urldecode and urlencode Jan 16, 2025
For the common cases, the generic and versatile syntax is really cumbersome.

Why exactly did we not add these earlier?
@nigoroll
Copy link
Member Author

This triggered #4255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants