Added ability to supply a different element as the scroll parent for scroll locking functionality#33
Open
mikekoser wants to merge 4 commits intovast-engineering:gh-pagesfrom
Open
Added ability to supply a different element as the scroll parent for scroll locking functionality#33mikekoser wants to merge 4 commits intovast-engineering:gh-pagesfrom
mikekoser wants to merge 4 commits intovast-engineering:gh-pagesfrom
Conversation
…scroll locking functionality (e.g. html instead of body). Added ability to supply additional css properties to apply to the scroll parent when a popup is closed and scroll locking is enabled.
…content from being shifted when showing/hiding popup with scroll lock.
… has a focus function defined prior to executing the .focus() call.
…tent from scrolling on touch scroll enabled devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #32
If the body is not the element on the page with scrolling enabled and you need to supply another element as the scroll parent (e.g. html instead of body).
Added ability to supply additional css properties to apply to the scroll parent when a popup is closed and scroll locking is enabled.