Open
Conversation
umpirsky
added a commit
to umpirsky/stajesti.rs
that referenced
this pull request
Jun 6, 2015
weberml2
referenced
this pull request
Jun 24, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My use case was finding workaround for #72.
Workaround was doing http://stackoverflow.com/questions/29101254/angularjs-slick-js-carousel-ng-click-not-firing-with-responsive-attribute-settin/30584787#30584787, but this worked only when resizing window, on mobile it still does not work. So I came up with
on-set-position="slickOnInit()"which used to fix it, but I need onSetPosition support.I added it as well as other events listed on https://github.com/kenwheeler/slick#events. It may be useful for many other use cases to have this events available.
@vasyabigi Please review and merge it as soon as you have time. Would be nice if you can release new version including this change.
Thanks.