Remove testmode config and pre-checkout customer creation#9
Merged
sandervanhooft merged 1 commit intomainfrom Mar 13, 2026
Merged
Remove testmode config and pre-checkout customer creation#9sandervanhooft merged 1 commit intomainfrom
sandervanhooft merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Issue #5: Remove VATLY_TESTMODE
The Vatly API infers testmode purely from the API key prefix (
test_= test mode). No need to configure or pass it explicitly.Changes:
testmodeconfig option fromconfig/vatly.phpVatlyConfig::isTestmode()to derive from API key prefix instead of configManagesTestmodetrait entirelyuse ManagesTestmodefromCheckoutBuilderandSubscriptionBuildertestmodefrom checkout payloadIssue #6: Remove ensureHasVatlyCustomer from checkout/subscribe
Don't pre-create customers before checkout. Let Vatly handle customer creation during checkout, then sync via webhooks. This fixes the 422 error when email already exists in Vatly.
Changes:
$this->ensureHasVatlyCustomer()call fromcheckout()method$this->ensureHasVatlyCustomer()call fromsubscribe()methodcustomerIdin payload will be null for new users (filtered out by array_filter)Closes #5
Closes #6