Add WTG tag item, VFR highlight and AIW inhibit#46
Open
arthuwu wants to merge 7 commits intovatsimhk:devfrom
Open
Add WTG tag item, VFR highlight and AIW inhibit#46arthuwu wants to merge 7 commits intovatsimhk:devfrom
arthuwu wants to merge 7 commits intovatsimhk:devfrom
Conversation
arthuwu
changed the title
EightSmart
reviewed
Feb 11, 2026
AT3/AT3Tags.cpp
Outdated
| colorAssumed = colorA; | ||
| colorNotAssumed = colorNA; | ||
| colorRedundant = colorR; | ||
| colorVFR = RGB(110, 205, 229); |
Member
There was a problem hiding this comment.
Please register colour constants in constant.hpp
| rteFile.close(); | ||
| rteFile.clear(); | ||
|
|
||
| fstream acftFile(acftPath); |
Member
There was a problem hiding this comment.
Need to handle error if acftPath is invalid
| auto kvp = wtgMap.find(icao); | ||
| if (kvp != wtgMap.end()) | ||
| { | ||
| return alias.find(kvp->second)->second; |
Member
There was a problem hiding this comment.
While this should theoretically never happen you should guard against alias.find() also returning nothing
| wtgMap[acft["ICAO"]] = acft["WTG"]; | ||
| } | ||
|
|
||
| acftJson = json(); // clear memory? |
Member
There was a problem hiding this comment.
What is the purpose of making acftJson a class variable if you only use it here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
(TopSky AIW will be disabled using exclusion areas in a future sector update)
WTGs are displayed using an alias to the ICAO WTG