Skip to content

fix: 优化文件下载器方法 #6617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+92 −2
Open

fix: 优化文件下载器方法 #6617

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df65501
fix: 优化文件下载器方法
lghuahua Aug 8, 2025
fddfc6d
fix: 增加对不支持的 HTTP 方法的错误处理
lghuahua Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/effects/request/src/request-client/modules/downloader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@
): Promise<T> {
const finalConfig: DownloadRequestConfig = {
responseReturn: 'body',
method: 'GET',
...config,
responseType: 'blob',
};

const response = await this.client.get<T>(url, finalConfig);
const response = await this.client.request<T>(url, finalConfig);

Check failure on line 36 in packages/effects/request/src/request-client/modules/downloader.ts

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest)

packages/effects/request/src/request-client/modules/downloader.test.ts > fileDownloader > should merge provided config with default config 

TypeError: this.client.request is not a function
 ❯ FileDownloader.download packages/effects/request/src/request-client/modules/downloader.ts:36:40
 ❯ packages/effects/request/src/request-client/modules/downloader.test.ts:49:41

Check failure on line 36 in packages/effects/request/src/request-client/modules/downloader.ts

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest)

packages/effects/request/src/request-client/modules/downloader.test.ts > fileDownloader > should download a file and return a Blob 

TypeError: this.client.request is not a function
 ❯ FileDownloader.download packages/effects/request/src/request-client/modules/downloader.ts:36:40
 ❯ packages/effects/request/src/request-client/modules/downloader.test.ts:28:41

return response;
}
Expand Down
Loading