Skip to content

Conversation

@xingyu4j
Copy link

@xingyu4j xingyu4j commented Nov 7, 2025

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Chores

    • Adjusted animation keyframe references used by accordion and collapsible animations.
    • Updated scroll area viewport selector to ensure correct scroll behavior across the UI.
    • Updated spell-check dictionary to include an additional term.
  • Documentation

    • Updated an inline documentation link for button composition guidance.

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: 0621654

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

Walkthrough

Updated framework references from "radix" to "reka" across config, CSS keyframes, a DOM selector, and an inline doc link; also added "reka" to the spell-check dictionary. No API signatures or control flow logic were otherwise changed.

Changes

Cohort / File(s) Summary
Spell-check dictionary
cspell.json
Added the word "reka" to the words list.
Tailwind / animations
internal/tailwind-config/src/index.ts
Replaced CSS variable references in four keyframes (accordion-down, accordion-up, collapsible-down, collapsible-up) from --radix-accordion-content-height / --radix-collapsible-content-height to --reka-accordion-content-height / --reka-collapsible-content-height.
Runtime selector
packages/@core/ui-kit/tabs-ui/src/use-tabs-view-scroll.ts
Changed DOM selector from div[data-radix-scroll-area-viewport] to div[data-reka-scroll-area-viewport] used for locating the scroll viewport.
Docs / inline comment
packages/@core/ui-kit/shadcn-ui/src/components/button/button.ts
Updated an inline documentation link/reference from Radix composition guide to the Reka UI composition guide (no functional change).

Sequence Diagram(s)

sequenceDiagram
  participant Tabs as Tabs logic
  participant DOM as Document
  Note over Tabs,DOM `#DFF2E1`: Scroll viewport detection (updated selector)
  Tabs->>DOM: querySelector("div[data-reka-scroll-area-viewport]")
  alt found
    DOM-->>Tabs: viewport element
    Tabs->>Tabs: compute scroll metrics & apply logic
  else not found
    DOM-->>Tabs: null
    Tabs->>Tabs: fallback behavior (no-op / default)
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to matching --reka- CSS variable names and data-reka-* attributes across related components.
  • Verify the updated documentation link is correct and intentional.

Suggested labels

bug

Suggested reviewers

  • anncwb
  • vince292007
  • jinmao88

Poem

🐰 I hopped through code with nimble feet,

Replacing "radix" where lines did meet.
A new word added — "reka" so spry,
Animations and selectors learned to fly,
I sniffed the docs and left a cheerful sigh. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely empty of substantive content—only the template structure remains with all sections unchecked. No explanation of the changes, motivation, or rationale is provided. Fill in the Description section with details about the changes and motivation. Check the appropriate 'Type of change' checkbox and mark relevant checklist items that were actually completed.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating Tailwind CSS variables from --radix-* to --reka-* across multiple files and components.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fba6a41 and 0621654.

📒 Files selected for processing (1)
  • packages/@core/ui-kit/shadcn-ui/src/components/button/button.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/@core/ui-kit/shadcn-ui/src/components/button/button.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: post-update (windows-latest)
  • GitHub Check: post-update (ubuntu-latest)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@likui628
Copy link
Collaborator

likui628 commented Nov 7, 2025

packages/@core/ui-kit/shadcn-ui/src/components/button/button.ts
这里的注释也改下

@likui628 likui628 changed the title fix: reka fix: updating Tailwind CSS variables from --radix-* to --reka-* Nov 7, 2025
@xingyu4j
Copy link
Author

xingyu4j commented Nov 7, 2025

packages/@core/ui-kit/shadcn-ui/src/components/button/button.ts 这里的注释也改下

OK了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants