[LOCKLITE-73] Display the list of vaults#57
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the display of user vaults in a new workspace page, establishing shared TypeScript types for component props and improving the request service architecture.
Key changes include:
- Creates a new workspace page that fetches and displays user vaults in a grid layout
- Introduces shared prop types for consistent component interfaces across layouts
- Enhances the request service with base URL configuration and improved parameter naming
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/ui/workspace/page.tsx | New page component that displays vaults in a responsive grid with loading and error states |
| src/app/ui/workspace/layout.tsx | Simple layout wrapper for the workspace section |
| src/modules/ui/gateways/vaults.gateway.ts | Gateway service for vault-related API calls using dependency injection |
| src/modules/shared/services/request.service.ts | Enhanced with base URL configuration and improved parameter naming |
| src/modules/shared/types/props/* | New shared prop types for consistent component interfaces |
| src/modules/ui/providers/ThemeRegistry.tsx | Updated to use shared prop types |
| src/modules/ui/components/common/PageContainer.tsx | Updated to use shared prop types |
| src/app/ui/layout.tsx | Updated to use shared prop types |
| src/app/api/layout.tsx | Updated to use shared prop types |
| src/app/ui/page.tsx | Renamed function for consistency |
| eslint.config.mjs | Added arrow-parens rule configuration |
| .prettierrc | Added arrowParens configuration |
| .prettierignore | Added GitHub release template to ignore list |
Files not reviewed (1)
- .idea/dictionaries/project.xml: Language not supported
This reverts commit 630b33f.
…liteApiRequestService that extends it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.