[LOCKLITE-80] Implement modal and button to create a vault#59
Merged
[LOCKLITE-80] Implement modal and button to create a vault#59
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a modal dialog and button functionality to create a new vault, completing the LOCKLITE-80 ticket. The changes introduce a complete create vault workflow with proper error handling and user interface integration.
- Added API gateway method for creating vaults with proper typing
- Created a reusable modal component with form validation and loading states
- Integrated the modal into the workspace page with proper state management and data refresh
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/modules/ui/gateways/vaults.gateway.ts | Added createVault method to handle vault creation API calls |
| src/modules/ui/components/modals/AddVaultModal.tsx | New modal component with form fields, error handling, and loading states |
| src/app/ui/workspace/page.tsx | Integrated add vault button and modal with automatic data refresh |
| <ErrorMessage error={error} /> | ||
| <DialogActions> | ||
| <Button onClick={props.onClose}>Cancel</Button> | ||
| <Button onClick={handleConfirm} variant="contained" loading={loading}> |
There was a problem hiding this comment.
The Material-UI Button component does not have a loading prop. You should use disabled={loading} instead or implement a custom loading state with a spinner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.