Skip to content

BKHK2023 Viscosity: set NaN for nonpositive taylor stress, warn once#242

Open
chrishavlin wants to merge 1 commit intovbr-calc:mainfrom
chrishavlin:adjust_BKHK2023_limits
Open

BKHK2023 Viscosity: set NaN for nonpositive taylor stress, warn once#242
chrishavlin wants to merge 1 commit intovbr-calc:mainfrom
chrishavlin:adjust_BKHK2023_limits

Conversation

@chrishavlin
Copy link
Copy Markdown
Member

This PR:

  • checks for Taylor Stress <= 0 in BKHK2023 and sets values to NaN.
  • adds outputs for the calculated taylor stress and threshold stress.
  • emits warnings once after the loop completes.

Close #241
Close #240

@chrishavlin chrishavlin added bug Something isn't working method: viscous something specific to a viscous method labels Apr 2, 2026
@chrishavlin
Copy link
Copy Markdown
Member Author

@Diede-Hein how's this for a fix?

@chrishavlin chrishavlin added this to the v2.1.1 milestone Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working method: viscous something specific to a viscous method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: BKHK2023 viscosity discontinuity BUG: BKHK2023 warning overwhelms console

1 participant