Skip to content

Sourcery Starbot ⭐ refactored vbrozik/fortigate2csv #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SourceryAI wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sourcery Starbot ⭐ refactored vbrozik/fortigate2csv #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions fortigate2csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,31 +275,26 @@ def build_csv(headers, rows, address_lookup=None):
row_data.append("")
else:
subitems = []
if (
header == "ipv4_addresses"
): # parse list, extract ip mask for each item within the field
for x in row[header]:
for x in row[header]:
if (
header == "ipv4_addresses"
): # parse list, extract ip mask for each item within the field
subitems.append(f"{x['ip']}/{x['cidr_netmask']}")
else: # parse list, extract q_origin_key for each item within the field
for x in row[header]:
if (
elif (
address_lookup
and x["q_origin_key"] in address_lookup
):
subitems.append(address_lookup[x["q_origin_key"]])
else:
subitems.append(x["q_origin_key"])
subitems.append(address_lookup[x["q_origin_key"]])
else:
subitems.append(x["q_origin_key"])
# join with a space, can't use comma due to csv
row_data.append(" ".join(map(str, subitems)))
elif type(row[header]) == str:
row_data.append(row[header].replace(",", ""))
elif address_lookup and row[header] in address_lookup:
subitems.append(address_lookup[row[header]])
else:
# this field is just a string/int, simply add it to the row
if type(row[header]) == str:
row_data.append(row[header].replace(",", ""))
else:
if address_lookup and row[header] in address_lookup:
subitems.append(address_lookup[row[header]])
else:
row_data.append(row[header])
row_data.append(row[header])
Comment on lines -278 to +297
Copy link
Author

@SourceryAI SourceryAI May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function build_csv refactored with the following changes:

This removes the following comments ( why? ):

# parse list, extract q_origin_key for each item within the field
# this field is just a string/int, simply add it to the row

else:
# display blanks where we have no info for this header
row_data.append("")
Expand Down