58 remove version management and enforcement#59
Conversation
- Updated the vCon class to remove mandatory versioning, allowing vCons to be created without the "vcon" field. - Adjusted related methods and tests to ensure compatibility with the new optional versioning. - Enhanced documentation to reflect changes in version handling and constructor behavior. - Updated tests to verify that vCons can be created and loaded without a version field, preserving existing functionality.
Added a comprehensive API reference for the vCon library in API_REFERENCE.md, detailing classes, methods, constants, and usage examples. Updated LLM_GUIDE.md to expand on vCon 0.3.0 features, including advanced party attributes, dialog types, extensions, civic address, party history, multimedia handling, security, validation, and best practices for LLM integration.
…agement - Revised API_REFERENCE.md to reflect the removal of the mandatory version field and the elimination of the `strict_version` parameter from method signatures. - Updated GUIDE.md to indicate that the `vcon` field is now optional and to provide examples of creating vCons without version fields. - Modified MIGRATION_GUIDE.md to outline changes in version management and provide migration steps for users transitioning to the new system. - Adjusted README.md and other documentation files to ensure consistency with the latest vCon specification updates.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on September 28
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: Optional Property Access Raises KeyError
The vcon property getter directly accesses self.vcon_dict["vcon"]. Since the vcon field is now optional (as indicated by the diff), accessing this property on objects without a version field will raise a KeyError. It should use .get("vcon") to return None when the field is absent, aligning with its Optional[str] return type.
src/vcon/vcon.py#L1876-L1885
src/vcon/vcon.py#L1419-L1420
Lines 1419 to 1420 in 44fe213
src/vcon/vcon.py#L1389-L1392
Lines 1389 to 1392 in 44fe213
src/vcon/vcon.py#L1895-L1898
src/vcon/vcon.py#L931-L934
Lines 931 to 934 in 44fe213
src/vcon/vcon.py#L1749-L1752
Comment @cursor review or bugbot run to trigger another review on this PR
- Updated index.html to redirect to the latest documentation and added a user-friendly message. - Removed obsolete vcon.html, dialog.html, and party.html files as part of the transition to the new documentation structure. - Introduced version_management.rst to document changes in version handling, including the optional nature of the version field and removal of strict version enforcement. - Updated conf.py to reflect the new version number (0.7.0) and adjusted index.rst to include the new version management section. - Modified tests to accommodate changes in the vCon class, ensuring compatibility with the new optional versioning system.
1 participant
No description provided.