Fix S3 storage to honor region configuration #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The S3 storage module was not passing the region_name parameter to the boto3 client, causing AWS to default to us-east-1. When buckets were in different regions, this caused AuthorizationHeaderMalformed errors. Changes: - Add _create_s3_client() helper that properly passes aws_region - Support endpoint_url for S3-compatible services (MinIO, LocalStack) - Update example_config.yml with region option - Rewrite README with accurate configuration documentation - Add comprehensive test suite (23 tests) Fixes region error reported by @mikeonslow 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 28
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Comment @cursor review or bugbot run to trigger another review on this PR
Co-authored-by: thomas.howe <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Tests now align with the refactored _build_s3_key helper that uses a simpler key format without date-based directories. Added 6 new tests for _build_s3_key helper function. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Without this file, pytest in Docker was incorrectly resolving tests/storage as the server/storage module, causing import errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
howethomas
added a commit
that referenced
this pull request
Jan 16, 2026
Fix S3 storage to honor region configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S3 storage module was not passing the region_name parameter to the boto3 client, causing AWS to default to us-east-1. When buckets were in different regions, this caused AuthorizationHeaderMalformed errors.
Changes:
Fixes region error reported by @mikeonslow
🤖 Generated with Claude Code
Note
S3 storage now passes aws_region and supports endpoint_url, with updated config/docs and a comprehensive test suite.
_create_s3_clientto passaws_regionand optionalendpoint_urltoboto3.client.save/getinserver/storage/s3/__init__.pyto use_create_s3_client; support optionals3_pathand date-based keys.example_config.ymlS3 options: addaws_region; document optionalendpoint_url,s3_path.server/storage/s3/README.mdwith accurate options, region guidance, features, key structure, and best practices.tests/storage/test_s3.pycovering client creation (regions/endpoints), save/get behavior, key prefixes, and error handling.tests/storage/__init__.py.Written by Cursor Bugbot for commit 3dcbf18. Configure here.