-
Notifications
You must be signed in to change notification settings - Fork 14
PrivatePath CLI Helper
#485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 77.84% 77.95% +0.11%
==========================================
Files 13 14 +1
Lines 1882 1901 +19
Branches 398 401 +3
==========================================
+ Hits 1465 1482 +17
- Misses 271 272 +1
- Partials 146 147 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
contract_user_homeusage caused inconsistent tilde-collapsingand risked leaking
$HOMEacross CLI commands and tests.rendering paths but otherwise behaves like
pathlib.Path.What
vcspull._internal.private_path.PrivatePath, apathlib.Pathsubclasswhose
str()/repr()collapse the current user's home directory.contract_user_home(or raw paths) so human output and JSON/NDJSON schemasnow consistently use
PrivatePath.vcspull.utiland update tests plus logsnapshots to expect the new behavior; add a dedicated test module for the
path class.
CHANGES(v1.47.x Development section) and theSphinx internals docs with usage guidelines and an
automodulereference.Testing