-
Notifications
You must be signed in to change notification settings - Fork 3
Create dotnet-desktop.yml #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,115 @@ | ||||||||||||||||||||||||||
| # This workflow uses actions that are not certified by GitHub. | ||||||||||||||||||||||||||
| # They are provided by a third-party and are governed by | ||||||||||||||||||||||||||
| # separate terms of service, privacy policy, and support | ||||||||||||||||||||||||||
| # documentation. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # This workflow will build, test, sign and package a WPF or Windows Forms desktop application | ||||||||||||||||||||||||||
| # built on .NET Core. | ||||||||||||||||||||||||||
| # To learn how to migrate your existing application to .NET Core, | ||||||||||||||||||||||||||
| # refer to https://docs.microsoft.com/en-us/dotnet/desktop-wpf/migration/convert-project-from-net-framework | ||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||
| # To configure this workflow: | ||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||
| # 1. Configure environment variables | ||||||||||||||||||||||||||
| # GitHub sets default environment variables for every workflow run. | ||||||||||||||||||||||||||
| # Replace the variables relative to your project in the "env" section below. | ||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||
| # 2. Signing | ||||||||||||||||||||||||||
| # Generate a signing certificate in the Windows Application | ||||||||||||||||||||||||||
| # Packaging Project or add an existing signing certificate to the project. | ||||||||||||||||||||||||||
| # Next, use PowerShell to encode the .pfx file using Base64 encoding | ||||||||||||||||||||||||||
| # by running the following Powershell script to generate the output string: | ||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||
| # $pfx_cert = Get-Content '.\SigningCertificate.pfx' -Encoding Byte | ||||||||||||||||||||||||||
| # [System.Convert]::ToBase64String($pfx_cert) | Out-File 'SigningCertificate_Encoded.txt' | ||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||
| # Open the output file, SigningCertificate_Encoded.txt, and copy the | ||||||||||||||||||||||||||
| # string inside. Then, add the string to the repo as a GitHub secret | ||||||||||||||||||||||||||
| # and name it "Base64_Encoded_Pfx." | ||||||||||||||||||||||||||
| # For more information on how to configure your signing certificate for | ||||||||||||||||||||||||||
| # this workflow, refer to https://github.com/microsoft/github-actions-for-desktop-apps#signing | ||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||
| # Finally, add the signing certificate password to the repo as a secret and name it "Pfx_Key". | ||||||||||||||||||||||||||
| # See "Build the Windows Application Packaging project" below to see how the secret is used. | ||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||
| # For more information on GitHub Actions, refer to https://github.com/features/actions | ||||||||||||||||||||||||||
| # For a complete CI/CD sample to get started with GitHub Action workflows for Desktop Applications, | ||||||||||||||||||||||||||
| # refer to https://github.com/microsoft/github-actions-for-desktop-apps | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| name: .NET Core Desktop | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| on: | ||||||||||||||||||||||||||
| push: | ||||||||||||||||||||||||||
| branches: [ "master" ] | ||||||||||||||||||||||||||
| pull_request: | ||||||||||||||||||||||||||
| branches: [ "master" ] | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| jobs: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| build: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| strategy: | ||||||||||||||||||||||||||
| matrix: | ||||||||||||||||||||||||||
| configuration: [Debug, Release] | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| runs-on: windows-latest # For a list of available runner types, refer to | ||||||||||||||||||||||||||
| # https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idruns-on | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| env: | ||||||||||||||||||||||||||
| Solution_Name: your-solution-name # Replace with your solution name, i.e. MyWpfApp.sln. | ||||||||||||||||||||||||||
| Test_Project_Path: your-test-project-path # Replace with the path to your test project, i.e. MyWpfApp.Tests\MyWpfApp.Tests.csproj. | ||||||||||||||||||||||||||
| Wap_Project_Directory: your-wap-project-directory-name # Replace with the Wap project directory relative to the solution, i.e. MyWpfApp.Package. | ||||||||||||||||||||||||||
| Wap_Project_Path: your-wap-project-path # Replace with the path to your Wap project, i.e. MyWpf.App.Package\MyWpfApp.Package.wapproj. | ||||||||||||||||||||||||||
|
Comment on lines
+59
to
+62
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| steps: | ||||||||||||||||||||||||||
| - name: Checkout | ||||||||||||||||||||||||||
| uses: actions/checkout@v4 | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||
| fetch-depth: 0 | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Install the .NET Core workload | ||||||||||||||||||||||||||
| - name: Install .NET Core | ||||||||||||||||||||||||||
| uses: actions/setup-dotnet@v4 | ||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||
| dotnet-version: 8.0.x | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Add MSBuild to the PATH: https://github.com/microsoft/setup-msbuild | ||||||||||||||||||||||||||
| - name: Setup MSBuild.exe | ||||||||||||||||||||||||||
| uses: microsoft/setup-msbuild@v2 | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Execute all unit tests in the solution | ||||||||||||||||||||||||||
| - name: Execute unit tests | ||||||||||||||||||||||||||
| run: dotnet test | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
cezary13k marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||||
| # Restore the application to populate the obj folder with RuntimeIdentifiers | ||||||||||||||||||||||||||
| - name: Restore the application | ||||||||||||||||||||||||||
| run: msbuild $env:Solution_Name /t:Restore /p:Configuration=$env:Configuration | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
| env: | ||||||||||||||||||||||||||
| Configuration: ${{ matrix.configuration }} | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Decode the base 64 encoded pfx and save the Signing_Certificate | ||||||||||||||||||||||||||
| - name: Decode the pfx | ||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||
| $pfx_cert_byte = [System.Convert]::FromBase64String("${{ secrets.Base64_Encoded_Pfx }}") | ||||||||||||||||||||||||||
| $certificatePath = Join-Path -Path $env:Wap_Project_Directory -ChildPath GitHubActionsWorkflow.pfx | ||||||||||||||||||||||||||
| [IO.File]::WriteAllBytes("$certificatePath", $pfx_cert_byte) | ||||||||||||||||||||||||||
|
Comment on lines
+91
to
+95
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Create the app package by building and packaging the Windows Application Packaging project | ||||||||||||||||||||||||||
| - name: Create the app package | ||||||||||||||||||||||||||
| run: msbuild $env:Wap_Project_Path /p:Configuration=$env:Configuration /p:UapAppxPackageBuildMode=$env:Appx_Package_Build_Mode /p:AppxBundle=$env:Appx_Bundle /p:PackageCertificateKeyFile=GitHubActionsWorkflow.pfx /p:PackageCertificatePassword=${{ secrets.Pfx_Key }} | ||||||||||||||||||||||||||
| env: | ||||||||||||||||||||||||||
| Appx_Bundle: Always | ||||||||||||||||||||||||||
| Appx_Bundle_Platforms: x86|x64 | ||||||||||||||||||||||||||
| Appx_Package_Build_Mode: StoreUpload | ||||||||||||||||||||||||||
| Configuration: ${{ matrix.configuration }} | ||||||||||||||||||||||||||
|
Comment on lines
+98
to
+104
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Remove the pfx | ||||||||||||||||||||||||||
| - name: Remove the pfx | ||||||||||||||||||||||||||
| run: Remove-Item -path $env:Wap_Project_Directory\GitHubActionsWorkflow.pfx | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
Comment on lines
+106
to
+109
|
||||||||||||||||||||||||||
| # Remove the pfx | |
| - name: Remove the pfx | |
| run: Remove-Item -path $env:Wap_Project_Directory\GitHubActionsWorkflow.pfx |
Copilot
AI
Feb 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The artifact name "MSIX Package" is misleading because this project doesn't produce MSIX packages. This is a simple console application that produces executable files. If artifacts are uploaded, the name should reflect what's actually being uploaded, such as "Build Output" or "Console Application Build".
| # Upload the MSIX package: https://github.com/marketplace/actions/upload-a-build-artifact | |
| - name: Upload build artifacts | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: MSIX Package | |
| # Upload the build artifacts: https://github.com/marketplace/actions/upload-a-build-artifact | |
| - name: Upload build artifacts | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: Build Output |
Copilot
AI
Feb 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The artifact path references $env:Wap_Project_Directory which is set to the placeholder "your-wap-project-directory-name" and the AppPackages subdirectory that doesn't exist in this repository. This will result in no artifacts being uploaded or an error. Since this is a console application, the appropriate artifacts would be the build output from bin/Debug or bin/Release.
| # Upload the MSIX package: https://github.com/marketplace/actions/upload-a-build-artifact | |
| - name: Upload build artifacts | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: MSIX Package | |
| path: ${{ env.Wap_Project_Directory }}\AppPackages | |
| # Upload the build output: https://github.com/marketplace/actions/upload-a-build-artifact | |
| - name: Upload build artifacts | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: Build Output | |
| path: '**\bin\${{ matrix.configuration }}\**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation comments (lines 1-37) describe a workflow for building, testing, signing and packaging WPF or Windows Forms desktop applications with MSIX packaging. However, this repository contains a simple console application without any GUI or packaging requirements. These comments are misleading and should be updated to reflect the actual purpose of the workflow, or the workflow should be redesigned to match the actual project structure.