Skip to content

ci: set cuda arch to native for ci workflows #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guocuimi merged 3 commits into from
Jun 17, 2025
Merged

ci: set cuda arch to native for ci workflows #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6a04c5
ci: set cuda arch to native for ci workflows
guocuimi Jun 17, 2025
0955102
add '-o --gpus=all'
guocuimi Jun 17, 2025
40de0b2
update
guocuimi Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
timeout-minutes: 60
run: |
./tools/run_in_docker.sh -ni ccache -M 25Gi
./tools/run_in_docker.sh -ni cmake -G Ninja -S . -B build -DCMAKE_CUDA_ARCHITECTURES=80
./tools/run_in_docker.sh -ni cmake -G Ninja -S . -B build
./tools/run_in_docker.sh -ni cmake --build build --config ${{env.BUILD_TYPE}} --target all

# - name: benchmark
Expand All @@ -79,4 +79,4 @@ jobs:
timeout-minutes: 10
working-directory: ${{github.workspace}}/build
# Execute tests defined by the CMake configuration.
run: ../tools/run_in_docker.sh -ni -o --gpus=all ctest --output-on-failure -C ${{env.BUILD_TYPE}}
run: ../tools/run_in_docker.sh -ni ctest --output-on-failure -C ${{env.BUILD_TYPE}}
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ endif()

# set architecture for CUDA
if (NOT DEFINED CMAKE_CUDA_ARCHITECTURES)
set(CMAKE_CUDA_ARCHITECTURES 80)
set(CMAKE_CUDA_ARCHITECTURES native)
endif()

# Build TORCH_CUDA_ARCH_LIST
Expand Down
4 changes: 2 additions & 2 deletions tools/run_in_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function usage() {
echo "Examples:"
echo " ${progname} cmake -G Ninja -S . -B build"
echo " ${progname} cmake --build build --target all"
echo " ${progname} -ni -d vectorchai/scalellm_devel:cuda12.8 -o '--gpus=all' ctest"
echo " ${progname} -ni -d vectorchai/scalellm_devel:cuda12.8 ctest"
echo ""
exit 1
}
Expand All @@ -39,7 +39,7 @@ function usage() {

# Default image
IMAGE="vectorchai/scalellm_devel:cuda12.8"
RUN_OPTS=()
RUN_OPTS=("--gpus=all")

INTERACTIVE=1
while [[ $# > 1 ]]; do
Expand Down