-
Notifications
You must be signed in to change notification settings - Fork 2k
enhancement(nats sink): add support for JetStream message headers #23510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+401
−238
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ae73048
feat: add templateable message header
benjamin-awd 916eb5c
refactor(tests): dry nats sink config
benjamin-awd 8b8ff6d
chore: add basic test for nats jetstream
benjamin-awd 4e0df73
chore: add test for dynamic message id
benjamin-awd 2dbade0
refactor: move headers under jetstream config block
benjamin-awd fb73fcb
chore: update nats sink docs
benjamin-awd b6caeaa
chore: add changelog
benjamin-awd d2b3c42
Merge branch 'master' into nats-sink-header
pront 3bbbe14
Merge branch 'master' into nats-sink-header
pront 9174f3b
chore: update nats sink docs
benjamin-awd 01edaf9
chore: add missing slash to docstring
benjamin-awd 11cfb57
chore: update nats sink docs
benjamin-awd 44c00ed
Merge branch 'master' into nats-sink-header
pront File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
changelog.d/23509_allow_headers_in_nats_jetstream_sink.enhancement.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| The `nats` sink now supports message headers when publishing to JetStream. | ||
|
|
||
| It introduces a configurable, templated Nats-Msg-Id header that ensures a unique ID for each message. This enables broker-level deduplication, resulting in stronger delivery guarantees and exactly-once semantics when combined with idempotent consumers. | ||
|
|
||
| authors: benjamin-awd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.